Skip to content

Implement JitInfo API - #55046

Merged
josalem merged 22 commits into
dotnet:mainfrom
josalem:dev/josalem/per-thread-jit-metrics
Jul 14, 2021
Merged

Implement JitInfo API#55046
josalem merged 22 commits into
dotnet:mainfrom
josalem:dev/josalem/per-thread-jit-metrics

Conversation

@josalem

@josalemjosalem commented Jul 1, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements #54444

This PR adds the System.Runtime.JitInfo static class and static methods. These are used for collecting information about the Just In Time compiler. As implemented, the API allows you retrieve:

  • The number of bytes of IL compiled
  • The number of methods compiled
  • The time spent compiling method

Some side-effects to this patch:

  • Adds a NormalizedTimer class to the CoreCLR utils for collecting time differences in 100ns ticks (the same ticks used by TimeSpan.FromTicks()). This should help avoid discrepancies in tick definitions between managed and native code.
  • Updates runtime counters to use new API
  • Updates eventpipe internals code for mono to include a icall that collects jit time values

CC @tommcdon@benmwatson@lateralusX

John Salem added 3 commits June 4, 2021 18:57
John Salem
Add JIT time metric
264a74f
* add per thread privately
* add test for counter
* add test for priuvate metric (currently failing due to linker I think)
John Salem
implement coreclr side
8c2ef38
John Salem
implement mono side
e63ed01
@josalemjosalem added this to the 6.0.0 milestone Jul 1, 2021
@josalemjosalem self-assigned this Jul 1, 2021
@ghost

ghost commented Jul 1, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements #54444

TODO:

  • disable API for browser/wasm
  • update test to handle 0 on Mono for currentThread = true
  • ensure /// docs are sufficient

Putting this up in draft form for some early feedback.

CC @tommcdon@benmwatson@lateralusX

Author:josalem
Assignees:josalem
Labels:

area-System.Runtime

Milestone:6.0.0

jkotas
jkotas reviewed Jul 1, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
reflectronic
reflectronic reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/JitInfo.cs
jkotas
jkotas reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
jkotas
jkotas reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.h Outdated
John Salem
Feedback and build fix
0e16d4a
* Fix mono build by adding mono partial class to csproj
* PR feedback
* no interlocked* for thread_local
* use CLR_BOOL
* use LARGE_INTEGER and only static_cast once
* correct ticks calculation
* convert Stopwatch methods to internal
* use same conversion as S.D.Stopwatch
reflectronic
reflectronic reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/JitInfo.cs Outdated
stephentoub
stephentoub reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Runtime/JitInfo.CoreCLR.cs
stephentoub
stephentoub reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Runtime/JitInfo.CoreCLR.cs Outdated
jkotas
jkotas reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/JitInfo.cs Outdated
stephentoub
stephentoub reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Runtime/JitInfo.CoreCLR.cs Outdated
stephentoub
stephentoub reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Runtime/JitInfo.cs Outdated
stephentoub
stephentoub reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/tests/tracing/eventcounter/perthreadjittime.cs Outdated
John Salem
PR feedback + adding ref source
064fd0c
* normalize ticks to 100ns in native code
* add NormalizedTimer class
* added source ref
* change ret value to long
jkotas
jkotas reviewed Jul 2, 2021
View reviewed changes
Comment threadsrc/coreclr/vm/util.hpp Outdated
John Salem added 5 commits July 2, 2021 17:29
John Salem
* use constructor instead of intiializer
780d8a9
* use double for frequency in case
clock resolution is larger than 100ns
John Salem
fix helper function visibility
1471a64
John Salem
Fix test failure
0dd2832
* test was attempting to parse ints when the interval
can be a double
John Salem
Improve test:
a7aa30a
* skip on aot platforms
* add current thread test for coreclr
John Salem
Further test improvements
5df31df
@josalem
josalem requested review from a team and lateralusXJuly 7, 2021 23:43
vargaz
vargaz reviewed Jul 8, 2021
View reviewed changes
Comment threadsrc/mono/mono/metadata/icall-eventpipe.c
noahfalk
noahfalk approved these changes Jul 8, 2021
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions on the tests, but overall lgtm!
I take it you have looked at some generated numbers manually to confirm the results look reasonable?

Comment threadsrc/coreclr/vm/util.hpp Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/Runtime/JitInfoTests.cs Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/Runtime/JitInfoTests.cs
Comment threadsrc/libraries/System.Runtime/tests/System/Runtime/JitInfoTests.cs Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/Runtime/JitInfoTests.cs Outdated
John Salem added 5 commits July 8, 2021 10:42
John Salem
PR feedback
dcfdfb7
* Removed Volatile<T> from globals
since they are all accessed either via InterlockedExchange
or VolatileLoad
* Added no tearing helper function for 32 bit systems
* updated tests to compare before and after
* added tests for AOT and Mono specific behaviors
* furether simplified NormalizedTimer class with asserts
John Salem
Fix typo in mono icalls
61f90db
John Salem
fix typo
39e8859
John Salem
remove unneeded cast
3546750
John Salem
Force interpretation of T as int64_t on x86
108d64d
@josalem

josalem commented Jul 8, 2021

Copy link
Copy Markdown
ContributorAuthor

Does anyone know a way to detect whether a test is being run under the Mono interpreter? If not, I'm going to modify the Mono flavor of the test to accept 0 and (after-before)==0.

@jkotas

jkotas commented Jul 8, 2021

Copy link
Copy Markdown
Member

PlatformDetection.IsMonoInterpreter ?

lambdageek
lambdageek reviewed Jul 9, 2021
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/Runtime/JitInfoTests.cs Outdated
jkotas
jkotas reviewed Jul 9, 2021
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/Runtime/JitInfoTests.cs Outdated
John Salem
Update tests based on PR feedback
45d846b
* use ref emit dynamic method
* adds IsNotMonoAot platform detection
@josalem

josalem commented Jul 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Barring any CI failures, I'm hoping to merge this later today.

@runfoapprunfoappBot mentioned this pull request Jul 13, 2021
Closed
@josalem

josalem commented Jul 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Remaining failure seems to be #55536.

@josalem

josalem commented Jul 13, 2021

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Jul 13, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@josalem

josalem commented Jul 14, 2021

Copy link
Copy Markdown
ContributorAuthor

I have a successful CI run; I'm intending to merge this PR this morning.

@josalem
josalem merged commit 21a7632 into dotnet:mainJul 14, 2021
@josalem
josalem deleted the dev/josalem/per-thread-jit-metrics branch July 14, 2021 17:47
@josalemjosalem mentioned this pull request Jul 15, 2021
Closed
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
This was referenced Jul 21, 2021
Closed
Closed
Closed
@karelzkarelz mentioned this pull request Jul 28, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek left review comments
@stephentoubstephentoubstephentoub left review comments
@jkotasjkotasjkotas left review comments
@tannergoodingtannergoodingtannergooding left review comments
@noahfalknoahfalknoahfalk approved these changes
@imhameedimhameedAwaiting requested review from imhameed
@marek-safarmarek-safarAwaiting requested review from marek-safar
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@thaystgthaystgAwaiting requested review from thaystgthaystg is a code owner
@lateralusXlateralusXAwaiting requested review from lateralusX
+2 more reviewers
@vargazvargazvargaz left review comments
@reflectronicreflectronicreflectronic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@josalemjosalem

Labels

area-System.Runtime

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

8 participants

@josalem@jkotas@vargaz@lambdageek@stephentoub@noahfalk@tannergooding@reflectronic