Uh oh!
There was an error while loading. Please reload this page.
Loop alignment: Handle blocks added in loop as part of split edges of LSRA - #55047
Merged
Conversation
If there are new blocks added by LSRA and modifies the flow of blocks that are in loop, then make sure that we do not align such loops if they intersect with last aligned loop.
kunalspathak
marked this pull request as ready for review
July 2, 2021 16:50
kunalspathak
commented
Jul 2, 2021
ContributorAuthor
@dotnet/jit-contrib |
BruceForstall
approved these changes
Jul 8, 2021
Uh oh!
There was an error while loading. Please reload this page.
kunalspathak
commented
Jul 8, 2021
ContributorAuthor
No asm diffs. The scenario mainly come in jitstressregs mode where we end up adding new blocks for resolution. |
ghost
commented
Jul 8, 2021
Hello @kunalspathak! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
kunalspathak
commented
Jul 8, 2021
ContributorAuthor
Formatting errors will be addressed in #55320 |
kunalspathak
commented
Jul 8, 2021
ContributorAuthor
One of the failure is #55315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are new blocks added by LSRA that modifies the flow of blocks that are in loop, then make sure that we do not align such
loops if they intersect with the last aligned loop.
Fixes some manifestation of #47094.