Skip to content

[wasm] WebSocket is already disposed by after abort. - #55075

Merged
pavelsavara merged 3 commits into
dotnet:mainfrom
pavelsavara:wasm_websocket_invalid_handle
Jul 12, 2021
Merged

[wasm] WebSocket is already disposed by after abort.#55075
pavelsavara merged 3 commits into
dotnet:mainfrom
pavelsavara:wasm_websocket_invalid_handle

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Jul 2, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#54152 the Invalid JS object handle '17'

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http labels Jul 2, 2021
@pavelsavara
pavelsavara requested review from lewing and radicalJuly 2, 2021 12:21
@ghost

ghost commented Jul 2, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54152

Author:pavelsavara
Assignees:-
Labels:

arch-wasm, area-System.Net.Http

Milestone:-

@pavelsavara
pavelsavara marked this pull request as ready for review July 2, 2021 12:34
pavelsavaraand others added 3 commits July 12, 2021 12:18
@pavelsavara
_innerWebSocket is already disposed by after abort.
2d567ea
@pavelsavara@campersau
Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebS…
39f38ba
…ockets/BrowserWebSockets/BrowserWebSocket.cs
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@pavelsavara@campersau
Update src/libraries/System.Net.WebSockets.Client/src/System/Net/WebS…
92e2705
…ockets/BrowserWebSockets/BrowserWebSocket.cs
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
@pavelsavara
pavelsavaraforce-pushed the wasm_websocket_invalid_handle branch from d8fad76 to 92e2705CompareJuly 12, 2021 10:22
@pavelsavara
pavelsavara merged commit f28318b into dotnet:mainJul 12, 2021
@karelzkarelz added this to the 6.0.0 milestone Jul 15, 2021
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@karelzkarelz mentioned this pull request Jul 20, 2021
Closed
@pavelsavara
pavelsavara deleted the wasm_websocket_invalid_handle branch July 29, 2021 08:45
@ghostghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@radicalradicalAwaiting requested review from radical
+1 more reviewer
@campersaucampersaucampersau left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-System.Net.Http

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

[wasm] System.Runtime.InteropServices.JavaScript.JSException: Invalid JS object handle '17'

4 participants

@pavelsavara@lewing@campersau@karelz