Uh oh!
There was an error while loading. Please reload this page.
[wasm][http] Improve compatibility of abort and cancelation of BrowserHttpHandler - #55084
Merged
Merged
Conversation
ghost
commented
Jul 2, 2021
Tagging subscribers to this area: @dotnet/ncl Issue Details
Fixes #54270
|
ManickaP
approved these changes
Jul 2, 2021
ManickaP
left a comment
Member
There was a problem hiding this comment.
LGTM, I'm not a browser handler expert though.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
… expectations
added [ActiveIssue("dotnet#55083", TestPlatforms.Browser)] for redirect outerloop testspavelsavaraforce-pushed
the
wasm_http_TaskCanceledException
branch
from
July 12, 2021 11:20
b17546d to
139ca9cComparemarek-safar
commented
Jul 13, 2021
Contributor
Is this ready for merge? |
lewing
approved these changes
Jul 13, 2021
Member
Failing test in runtime (Libraries Test Run release mono Linux x64 Debug) is It isn't related to to a browser only change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#54270