Skip to content

[wasm][http] Improve compatibility of abort and cancelation of BrowserHttpHandler - #55084

Merged
lewing merged 3 commits into
dotnet:mainfrom
pavelsavara:wasm_http_TaskCanceledException
Jul 13, 2021
Merged

[wasm][http] Improve compatibility of abort and cancelation of BrowserHttpHandler#55084
lewing merged 3 commits into
dotnet:mainfrom
pavelsavara:wasm_http_TaskCanceledException

Conversation

@pavelsavara

Copy link
Copy Markdown
Member

Fixes#54270

@pavelsavara
pavelsavara marked this pull request as ready for review July 2, 2021 15:06
@pavelsavarapavelsavara added the arch-wasm WebAssembly architecture label Jul 2, 2021
@ghost

ghost commented Jul 2, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #54270

Author:pavelsavara
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@ManickaPManickaP left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not a browser handler expert though.

… expectations
added [ActiveIssue("dotnet#55083", TestPlatforms.Browser)] for redirect outerloop tests
@pavelsavara
pavelsavaraforce-pushed the wasm_http_TaskCanceledException branch from b17546d to 139ca9cCompareJuly 12, 2021 11:20
@marek-safar

Copy link
Copy Markdown
Contributor

Is this ready for merge?

@lewing

lewing commented Jul 13, 2021

Copy link
Copy Markdown
Member

Failing test in runtime (Libraries Test Run release mono Linux x64 Debug) is

 Starting: System.Threading.Tests (parallel test collections = on, max threads = 2)
System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest8_Values_NegativeCases [SKIP]
Condition(s) not met: "IsPreciseGcSupported"
System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest5_Dispose [FAIL]
Assert.True() Failure
Expected: True
Actual: False
Stack Trace:
/_/src/libraries/System.Threading/tests/ThreadLocalTests.cs(139,0): at System.Threading.Tests.ThreadLocalTests.RunThreadLocalTest5_Dispose()
/_/src/mono/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs(370,0): at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

It isn't related to to a browser only change.

@lewing
lewing merged commit dc2d0cc into dotnet:mainJul 13, 2021
@karelzkarelz added this to the 6.0.0 milestone Jul 15, 2021
@pavelsavara
pavelsavara deleted the wasm_http_TaskCanceledException branch July 29, 2021 08:45
@ghostghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-System.Net.Http

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm][http] System.Net.Http.Functional.Tests.HttpClientTest - Expected: System.Threading.Tasks.TaskCanceledException

6 participants

@pavelsavara@marek-safar@lewing@stephentoub@ManickaP@karelz