Skip to content

[release/6.0-preview6][Mono] Condition Workload AOT import to be osx only - #55091

Merged
steveisok merged 1 commit into
dotnet:release/6.0-preview6from
lewing:backport-55040-to-preview6
Jul 2, 2021
Merged

[release/6.0-preview6][Mono] Condition Workload AOT import to be osx only#55091
steveisok merged 1 commit into
dotnet:release/6.0-preview6from
lewing:backport-55040-to-preview6

Conversation

@lewing

@lewinglewing commented Jul 2, 2021

Copy link
Copy Markdown
Member

Backport of #55040 [Mono] Condition Workload AOT import to be osx only

If we don't, then the aot packs will be imported on Windows when running an iOS offline build

Fixes#54944

Customer Impact

Avoids incorrect imports that will cause problems on platforms other than osx.

Testing

Manual testing.

Risk

Low, it add restrictions to imported properties

@lewinglewing added the Servicing-consider Issue for next servicing release review label Jul 2, 2021
@lewing
lewing requested a review from marek-safar as a code ownerJuly 2, 2021 17:21
@ghostghost added the area-System.Net label Jul 2, 2021
@ghost

ghost commented Jul 2, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:lewing
Assignees:-
Labels:

Servicing-consider, area-System.Net

Milestone:-

@lewing
lewingforce-pushed the backport-55040-to-preview6 branch from fddaab4 to ce9815eCompareJuly 2, 2021 17:24
@lewing
lewingforce-pushed the backport-55040-to-preview6 branch from ce9815e to 03fe89cCompareJuly 2, 2021 17:25
@lewing
lewing requested a review from steveisokJuly 2, 2021 17:26
@lewinglewing changed the title Backport #55040 to preview6[release/6.0-preview6][Mono] Condition Workload AOT import to be osx onlyJul 2, 2021
@steveisoksteveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 2, 2021
@steveisok

Copy link
Copy Markdown
Member

This change was approved in an email.

@steveisok
steveisok merged commit 770d630 into dotnet:release/6.0-preview6Jul 2, 2021
@lewing
lewing deleted the backport-55040-to-preview6 branch July 2, 2021 21:29
@karelzkarelz added this to the 6.0.0 milestone Jul 15, 2021
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.NetServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lewing@steveisok@karelz