Uh oh!
There was an error while loading. Please reload this page.
Fix helloworld on x86 Linux - #55095
Merged
Merged
Conversation
jkotas
commented
Jul 2, 2021
Member
It looks like a reasonable direction to me. |
t-mustafinforce-pushed
the
fix_x86_linux_helloworld
branch
from
July 7, 2021 17:09
22834b4 to
1644a0eComparet-mustafin
marked this pull request as ready for review
July 7, 2021 17:11
jkotas
commented
Jul 7, 2021
Member
A lot of tests on Windows x64 are failing with errors like: |
t-mustafinforce-pushed
the
fix_x86_linux_helloworld
branch
from
July 7, 2021 22:18
1644a0e to
df48ae4Comparet-mustafinforce-pushed
the
fix_x86_linux_helloworld
branch
from
July 8, 2021 12:21
df48ae4 to
a6f9fcbComparejkotas
reviewed
Jul 8, 2021
Member
There was a problem hiding this comment.
VarArgs is not supported on Unix, so this will be always false. Would it be better to put this whole block under #ifndef UNIX_X86_ABI ?
Make managed->managed call use of ecx, edx to pass first two arguments. Make stack alignment returning after call.
t-mustafinforce-pushed
the
fix_x86_linux_helloworld
branch
from
July 9, 2021 14:46
a6f9fcb to
d1b6466Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on helloworld.dll x86 linux launch I've got problem during calling convention on managed call from managed code. I fixed it in morph.cpp. After that fix I had got bugs with stack misalignment. Couple of that problems I fixed in compiler.cpp and jitinterfacex86.cpp. It allows to run helloworld.dll and stack dumping with
System.Diagnostics.StackTrace. But I still have got similar stack misalignment problems on another programs.Is that fix-work direction right? Maybe I should fix managed-managed calling convention in another way?
cc @jkotas@alpencolt