Skip to content

Use RandomAccess/File.OpenHandle in a few more places - #55150

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:morehandle
Jul 9, 2021
Merged

Use RandomAccess/File.OpenHandle in a few more places#55150
stephentoub merged 1 commit into
dotnet:mainfrom
stephentoub:morehandle

Conversation

@stephentoub

@stephentoubstephentoub commented Jul 4, 2021

Copy link
Copy Markdown
Member

Places where we don't need to pay for the FileStream and the access pattern is easily replaced.

@ghostghost added the area-System.IO label Jul 4, 2021
@ghost

ghost commented Jul 4, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Places where we don't need to pay for the FileStream and the access pattern is easily replaced.

Author:stephentoub
Assignees:-
Labels:

area-System.IO

Milestone:-

@stephentoub

stephentoub commented Jul 4, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This fails because of MS_IO_REDIST, and it's too annoying to use ifdefs everywhere for it. We should really consider stopping building this package.

cc: @adamsitnik

@stephentoubstephentoub reopened this Jul 4, 2021
@stephentoub

stephentoub commented Jul 4, 2021

Copy link
Copy Markdown
MemberAuthor

Updated with undos for the File changes that would have required large ifdefs.

@adamsitnik

adamsitnik commented Jul 5, 2021

Copy link
Copy Markdown
Member

This fails because of MS_IO_REDIST, and it's too annoying to use ifdefs everywhere for it. We should really consider stopping building this package.

We plan to reevaluate this package for .NET 7 and hopefully remove it #54919 (comment) cc @jeffhandley

adamsitnik
adamsitnik reviewed Jul 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/File.cs Outdated
adamsitnik
adamsitnik reviewed Jul 8, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/File.cs Outdated
Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/File.cs Outdated
adamsitnik
adamsitnik approved these changes Jul 8, 2021
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope that you enjoyed using the new APIs ;)

Comment threadsrc/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs Outdated
@stephentoub
Use RandomAccess/File.OpenHandle in a few more places
a2e0a7c
Places where we don't need to pay for the FileStream and the access pattern is easily replaced.
@stephentoub
stephentoub merged commit fe9005f into dotnet:mainJul 9, 2021
@stephentoub
stephentoub deleted the morehandle branch July 9, 2021 23:47
@runfoapprunfoappBot mentioned this pull request Jul 15, 2021
Closed
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

No one assigned

Labels

area-System.IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub@adamsitnik