Skip to content

Override the APM methods on AsyncWindowsFileStreamStrategy. - #55203

Merged
stephentoub merged 4 commits into
dotnet:mainfrom
teo-tsirpanis:async-windows-io-apm
Jul 14, 2021
Merged

Override the APM methods on AsyncWindowsFileStreamStrategy.#55203
stephentoub merged 4 commits into
dotnet:mainfrom
teo-tsirpanis:async-windows-io-apm

Conversation

@teo-tsirpanis

@teo-tsirpanisteo-tsirpanis commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

Closes#55172.

@ghostghost added the area-System.IO label Jul 6, 2021
@ghost

ghost commented Jul 6, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #55172.

Author:teo-tsirpanis
Assignees:-
Labels:

area-System.IO

Milestone:-

stephentoub
stephentoub reviewed Jul 9, 2021
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comments, LGTM. Thanks.

@teo-tsirpanis

teo-tsirpanis commented Jul 10, 2021

Copy link
Copy Markdown
ContributorAuthor

OK, feedback is addressed.

@stephentoub
stephentoub merged commit 95044fd into dotnet:mainJul 14, 2021
@stephentoub

stephentoub commented Jul 14, 2021

Copy link
Copy Markdown
Member

Thanks!

@teo-tsirpanis
teo-tsirpanis deleted the async-windows-io-apm branch July 14, 2021 19:29
@adamsitnikadamsitnik added this to the 6.0.0 milestone Jul 19, 2021
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@karelzkarelz mentioned this pull request Jul 27, 2021
Closed
@GSPP

GSPP commented Aug 15, 2021

Copy link
Copy Markdown

This was a pretty severe bug. I just had an idea on how this could be avoided in the future: Write a reflection-based test that makes sure that all Stream read and write methods are overridden in all BCL classes.

@ghostghost locked as resolved and limited conversation to collaborators Sep 14, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

No one assigned

Labels

area-System.IO

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

FileStream.BeginRead/Write with useAsync no longer use overlapped I/O

4 participants

@teo-tsirpanis@stephentoub@GSPP@adamsitnik