Skip to content

Add missing extra jit flag dump entries - #55280

Merged
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:FixExtraJitFlagsDump
Jul 8, 2021
Merged

Add missing extra jit flag dump entries#55280
AndyAyersMS merged 1 commit into
dotnet:mainfrom
AndyAyersMS:FixExtraJitFlagsDump

Conversation

@AndyAyersMS

Copy link
Copy Markdown
Member

Fix missing flag entries that are displayed in various contexts, eg mcs -jitflags

Before:

Individual Flag Appearances
...
23587 54.18% TIER0
15818 36.34% TIER1
9531 21.89% Unknown jit flags-0400000000000000
1725 3.96% Unknown jit flags-0800000000000000
489 1.12% HAS_LIKELY_CLASS
2927 6.72% HAS_CLASS_PROFILE
11256 25.86% HAS_EDGE_PROFILE
11256 25.86% HAS_PGO

After:

Individual Flag Appearances
...
23587 54.18% TIER0
15818 36.34% TIER1
9531 21.89% HAS_DYNAMIC_PROFILE
1725 3.96% HAS_STATIC_PROFILE
489 1.12% HAS_LIKELY_CLASS
2927 6.72% HAS_CLASS_PROFILE
11256 25.86% HAS_EDGE_PROFILE
11256 25.86% HAS_PGO

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 7, 2021
@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib

@AndyAyersMS

Copy link
Copy Markdown
MemberAuthor

One infra issue (installer), one unrelated test failure that seems like an instance of #54941.

 Common.Tests.cgroupsTests.ValidateFindCGroupVersion [FAIL]
System.TypeLoadException : GenericArguments[0], 'System.Int32', on 'System.IBinaryInteger`1[TSelf]' violates the constraint of type parameter 'TSelf'.
Stack Trace:
/_/src/libraries/Common/tests/Tests/Interop/cgroupsTests.cs(14,0): at Common.Tests.cgroupsTests.ValidateFindCGroupVersion()

@AndyAyersMS
AndyAyersMS merged commit f30c848 into dotnet:mainJul 8, 2021
@AndyAyersMS
AndyAyersMS deleted the FixExtraJitFlagsDump branch July 8, 2021 16:50
@runfoapprunfoappBot mentioned this pull request Jul 10, 2021
@ghostghost locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyAyersMS@EgorBo