Skip to content

Fix JsonConstructorAttribute duplicate exception message - #55324

Merged
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
Tornhoof:FixStjException
Jul 13, 2021
Merged

Fix JsonConstructorAttribute duplicate exception message#55324
eiriktsarpalis merged 1 commit into
dotnet:mainfrom
Tornhoof:FixStjException

Conversation

@Tornhoof

@TornhoofTornhoof commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

Closes#55321

  • Changed text to member instead of property
  • Changed typeof to use TAttribute

@ghost

ghost commented Jul 8, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #55321

  • Changed text to member instead of property
  • Changed typeof to use TAttribute
Author:Tornhoof
Assignees:-
Labels:

area-System.Text.Json

Milestone:-

stephentoub
stephentoub approved these changes Jul 9, 2021
View reviewed changes

@stephentoubstephentoub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

eiriktsarpalis
eiriktsarpalis approved these changes Jul 13, 2021
View reviewed changes

@eiriktsarpaliseiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eiriktsarpalis
eiriktsarpalis merged commit 0aa781c into dotnet:mainJul 13, 2021
@Tornhoof
Tornhoof deleted the FixStjException branch July 13, 2021 13:31
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@jozkeejozkeeAwaiting requested review from jozkee
@layomialayomiaAwaiting requested review from layomia
@stevehartersteveharterAwaiting requested review from steveharter

Assignees

No one assigned

Labels

area-System.Text.Json

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong Exception Text for duplicate JsonConstructorAttribute

3 participants

@Tornhoof@stephentoub@eiriktsarpalis