Uh oh!
There was an error while loading. Please reload this page.
Expose the platform directly for apple products - #55381
Conversation
Uh oh!
There was an error while loading. Please reload this page.
lewing
commented
Jul 9, 2021
all infrastructure failures |
…acos runtime packs & cleaned up a few errors
steveisok
commented
Jul 12, 2021
@rolfbjarne With this change, you'll need to remove the RuntimeConfig imports that are in your |
| <Import Project="Sdk.targets" Sdk="Microsoft.NET.Runtime.MonoTargets.Sdk" /> | ||
| </ImportGroup> | ||
| <PropertyGroup Condition="'$(TargetPlatformIdentifier)' == 'android' or '$(TargetPlatformIdentifier)' == 'macOS' or '$(TargetPlatformIdentifier)' == 'ios' or '$(TargetPlatformIdentifier)' == 'maccatalyst' or '$(TargetPlatformIdentifier)' == 'tvos' or ('$(RuntimeIdentifier)' == 'browser-wasm' and '$(UsingBrowserRuntimeWorkload)' == 'true')"> |
There was a problem hiding this comment.
Is this a strict enough check on macOS?
There was a problem hiding this comment.
I thought it wasn't at first, but I believe macOS is the TFM for xam.mac. So, we wouldn't be interfering w/ anything else.
steveisok
commented
Jul 12, 2021
Failure is helix instance not having openssl installed and is unrelated. |
| <KnownRuntimePack Remove="Microsoft.NETCore.App" /> | ||
| <KnownRuntimePack Include="Microsoft.NETCore.App" | ||
| TargetFramework="net6.0" |
There was a problem hiding this comment.
@lewing@steveisok while this works for now, it'll break once we move to net7.0. Can you try whether doing this instead of the Remove works:
<KnownRuntimePackUpdate="Microsoft.NETCore.App"LatestRuntimeFrameworkVersion="$(_MonoWorkloadRuntimePackPackageVersion)"Condition="'%(RuntimePackLabels)' == 'Mono' and '%(TargetFramework)' == 'net$(TargetFrameworkVersion)'"
Fixes#54996
Fixes#53579