Skip to content

Update wasm workload name to wasm-tools - #55413

Merged
lewing merged 2 commits into
dotnet:mainfrom
lewing:wasm-rename
Jul 10, 2021
Merged

Update wasm workload name to wasm-tools#55413
lewing merged 2 commits into
dotnet:mainfrom
lewing:wasm-rename

Conversation

@lewing

@lewinglewing commented Jul 9, 2021

Copy link
Copy Markdown
Member

Change microsoft-net-sdk-blazorwebassembly-aot to wasm-tools

Every other workload in the file is abstract and probably shouldn't have a short name.

@ghost

ghost commented Jul 9, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@danroth27danroth27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lewing

lewing commented Jul 9, 2021

Copy link
Copy Markdown
MemberAuthor

@lewing

Copy link
Copy Markdown
MemberAuthor

@joeloff throwing another feature into the mix

@lewing
lewing requested a review from mhutchJuly 9, 2021 18:15
@lewing

lewing commented Jul 9, 2021

Copy link
Copy Markdown
MemberAuthor

@mhutch looks like dotnet/sdk#18166 isn't in yet?

We can remove the redirect-to but there is a lot of existing tooling/instruction that uses the old name and things will break until they are updated.

@mhutch

Copy link
Copy Markdown
Contributor

@lewing it looks like redirects won't make it for .NET 6 as we're not 100% confident they won't have unexpected side effects as currently implemented. I think we just have to take the breaking change while we're in preview, sorry :/

@lewing

Copy link
Copy Markdown
MemberAuthor

@lewing it looks like redirects won't make it for .NET 6 as we're not 100% confident they won't have unexpected side effects as currently implemented. I think we just have to take the breaking change while we're in preview, sorry :/

It's not a problem, I was just hoping to avoid breaking the world again this week.

@lewing

Copy link
Copy Markdown
MemberAuthor

I'm going to land this later tonight unless there are strong objections.

@lewing
lewing requested a review from SamMonoRTJuly 10, 2021 00:50
@lewing
lewing merged commit f22685f into dotnet:mainJul 10, 2021
@lewing
lewing deleted the wasm-rename branch July 10, 2021 01:10
@SamMonoRT

Copy link
Copy Markdown
Member

@naricc - possibly this affects the BDN Microbenchmark runs ?

@lewinglewing changed the title Update wasm workload nameUpdate wasm workload name to wasm-toolsJul 12, 2021
@lewing
lewing requested a review from mkArtakMSFTJuly 12, 2021 18:12
directhex pushed a commit to directhex/runtime that referenced this pull request Jul 14, 2021
@ghostghost locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@lewing@mhutch@SamMonoRT@steveisok@danroth27