Skip to content

Disable tests blocking CI - #55446

Merged
hoyosjs merged 4 commits into
mainfrom
juhoyosa/disable-tests
Jul 10, 2021
Merged

Disable tests blocking CI#55446
hoyosjs merged 4 commits into
mainfrom
juhoyosa/disable-tests

Conversation

@hoyosjs

@hoyosjshoyosjs commented Jul 10, 2021

Copy link
Copy Markdown
Member

Disables tests for #55271 and #55435

@hoyosjs
hoyosjs requested a review from a teamJuly 10, 2021 03:47
@ghostghost added the area-System.Net label Jul 10, 2021
@ghost

ghost commented Jul 10, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Disables tests for #55271 and #55435

Author:hoyosjs
Assignees:-
Labels:

area-System.Net

Milestone:-

safern
safern approved these changes Jul 10, 2021
View reviewed changes

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc: @wfurt

wfurt
wfurt reviewed Jul 10, 2021
View reviewed changes
Comment threadsrc/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostByNameTest.cs Outdated
wfurt
wfurt reviewed Jul 10, 2021
View reviewed changes
Comment threadsrc/libraries/System.Net.NameResolution/tests/FunctionalTests/GetHostEntryTest.cs Outdated
@hoyosjs
hoyosjsforce-pushed the juhoyosa/disable-tests branch from 8121863 to 2464929CompareJuly 10, 2021 09:10
@ghost

ghost commented Jul 10, 2021

Copy link
Copy Markdown

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@hoyosjs
hoyosjsforce-pushed the juhoyosa/disable-tests branch from 2464929 to 314c759CompareJuly 10, 2021 09:39
@steveisok

steveisok commented Jul 10, 2021

Copy link
Copy Markdown
Member

The mono linux x64 failure looks like a flake.

@hoyosjs

hoyosjs commented Jul 10, 2021

Copy link
Copy Markdown
MemberAuthor

Yeah, Connect_DualMode_DnsConnect_RetrievedEndPoints_Success was under investigation. I know @antonfirsov changed something in this test recently to try to remove the flakiness.

@hoyosjs
hoyosjs merged commit 960e7b3 into mainJul 10, 2021
@hoyosjs
hoyosjs deleted the juhoyosa/disable-tests branch July 10, 2021 20:01
@ManickaP

ManickaP commented Jul 12, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Related https://github.com/dotnet/core-eng/issues/13675
Some of the tests seem like an infra issue.

@karelzkarelz mentioned this pull request Jul 13, 2021
Closed
@karelzkarelz added this to the 6.0.0 milestone Jul 15, 2021
@runfoapprunfoappBot mentioned this pull request Jul 15, 2021
Closed
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@halter73halter73 mentioned this pull request Aug 9, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurtwfurtwfurt left review comments
@safernsafernsafern approved these changes

Assignees

No one assigned

Labels

area-System.Net

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hoyosjs@steveisok@ManickaP@wfurt@safern@karelz