Uh oh!
There was an error while loading. Please reload this page.
One shot CFB - #55480
Conversation
ghost
commented
Jul 11, 2021
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
commented
Jul 11, 2021
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis implements CFB one shots. Some implementation notes:
Closes #2406
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vcsjones
commented
Jul 12, 2021
Mono failures should be fixed by #55482. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
bartonjs
commented
Jul 12, 2021
Looks like all I had were a couple of nitpicky things. Nice work. |
bartonjs
commented
Jul 12, 2021
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vcsjones
commented
Jul 12, 2021
Seems like Pipeline's NuGet feed is cranky. |
bartonjs
commented
Jul 13, 2021
The outerloop failures aren't related, just waiting on the Linux-Debug leg to finish. |
This implements CFB one shots.
Some implementation notes:
AesCngandTripleDESCngone shots will throw if the key is persisted and the feedback size is other than 8. This limitation can be removed, if it is possible, when the linked issue is solved.ICryptoTransformCFB implementation. The CNG CFB128 /CFB64 persisted-key remain as-is (using CFB8).Closes#2406