Uh oh!
There was an error while loading. Please reload this page.
Add tests for generic types/values with the Marshal APIs - #55533
Merged
Conversation
…depending on optimization settings.
jkoritzinskyforce-pushed
the
offset-of-generic
branch
from
July 12, 2021 22:05
a67b930 to
26fc4d1Compare
This was referenced Jul 13, 2021
Uh oh!
There was an error while loading. Please reload this page.
jkoritzinsky
commented
Jul 13, 2021
MemberAuthor
I've added more tests based on the discussion in #35193 |
elinor-fung
approved these changes
Jul 14, 2021
jkoritzinsky
commented
Jul 14, 2021
MemberAuthor
This PR is only test changes and the failures are in unrelated tests. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests that validate the current behavior of OffsetOf with generic types
Fixes#35193