Skip to content

Simplify PosixSignalRegistration implementation on Unix - #55552

Merged
stephentoub merged 4 commits into
dotnet:mainfrom
stephentoub:psrunixrefactor
Jul 13, 2021
Merged

Simplify PosixSignalRegistration implementation on Unix#55552
stephentoub merged 4 commits into
dotnet:mainfrom
stephentoub:psrunixrefactor

Conversation

@stephentoub

@stephentoubstephentoub commented Jul 13, 2021

Copy link
Copy Markdown
Member

Bring it onto the same scheme as the Windows implementation.
cc: @tmds, @jkotas

@stephentoubstephentoub mentioned this pull request Jul 13, 2021
Closed
jkotas
jkotas approved these changes Jul 13, 2021
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephentoub
Simplify PosixSignalRegistration implementation on Unix
6ff1beb
Bring it onto the same scheme as the Windows implementation.
@stephentoub
Address PR feedback
b5a86a1
@MaximLipnin

MaximLipnin commented Jul 13, 2021

Copy link
Copy Markdown
Contributor

@stephentoub Can these changes fix #55563 ?

@stephentoub

stephentoub commented Jul 13, 2021

Copy link
Copy Markdown
MemberAuthor

Can these changes fix #55563 ?

No

tmds
tmds approved these changes Jul 13, 2021
View reviewed changes

@tmdstmds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stephentoub
stephentoub merged commit 4f9deeb into dotnet:mainJul 13, 2021
@stephentoub
stephentoub deleted the psrunixrefactor branch July 13, 2021 19:39
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
+1 more reviewer
@tmdstmdstmds approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Runtime.InteropServices

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@MaximLipnin@tmds@jkotas