Skip to content

[wasm] Misc follow up improvements for workloads testing - #55647

Merged
lewing merged 7 commits into
dotnet:mainfrom
radical:wasm-workloads-followup
Jul 15, 2021
Merged

[wasm] Misc follow up improvements for workloads testing#55647
lewing merged 7 commits into
dotnet:mainfrom
radical:wasm-workloads-followup

Conversation

@radical

@radicalradical commented Jul 14, 2021•
edited
Loading

Copy link
Copy Markdown
Member
  • Addresses some suggestions from Larry Ewing
  • And fixes emcc cache-info messages breaking the build because get are on stderr, and get logged as warnings.
  • Improve logging a bit to track EmccCompile's parallel emcc output
  • Change Emscripten version mismatch to a warning

@radicalradical added the arch-wasm WebAssembly architecture label Jul 14, 2021
@ghost

ghost commented Jul 14, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:radical
Assignees:-
Labels:

arch-wasm

Milestone:-

@ghostghost added the area-Build-mono label Jul 14, 2021
@radical
[wasm] Move UseMonoRuntime=true to WasmApp.props
eb24b84
@radical
Move workloads installation for testing bits to
92a0ac8
.. `src/libraries/workloads-testing.targets`.
@radical
[wasm] EmccCompile: don't log stderr messages as warnings
975a3f0
emcc emits some (debug?) messages on stderr too, which are not always
errors. Emitting them as warning can be break the build too, when
running with warningsAsErrors .
@radical
[wasm] Fix helix work item prefix
b6e098e
@radical
radicalforce-pushed the wasm-workloads-followup branch from 3d479a2 to b6e098eCompareJuly 14, 2021 15:11
@lewing

lewing commented Jul 14, 2021

Copy link
Copy Markdown
Member

/azp run runtime,runtime-staging

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@lewing

lewing commented Jul 15, 2021

Copy link
Copy Markdown
Member

runtime (CoreCLR Product Build Linux arm64 checked)

Starting: Publish product build
==============================================================================
Task : Publish build artifacts
Description : Publish build artifacts to Azure Pipelines or a Windows file share
Version : 1.186.0
Author : Microsoft Corporation
Help : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/publish-build-artifacts
==============================================================================
Async Command Start: Upload Artifact
Async Command End: Upload Artifact
##[error]Network is unreachable
Finishing: Publish product build

@lewing

lewing commented Jul 15, 2021

Copy link
Copy Markdown
Member

Failure was unrelated

@lewing
lewing merged commit bcc7944 into dotnet:mainJul 15, 2021
@radical
radical deleted the wasm-workloads-followup branch July 15, 2021 21:47
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@karelzkarelz mentioned this pull request Jul 20, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radical@lewing