[wasm] Support mono runtime components by radekdoulik · Pull Request #55680 · dotnet/runtime

radekdoulik · 2021-07-14T20:47:12Z

This should fix#55608

Context: #54565

ghost · 2021-07-14T20:47:17Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Author:	radekdoulik
Assignees:	-
Labels:	`arch-wasm`, `area-Codegen-AOT-mono`
Milestone:	-

lewing

LGTM, lets wait for @radical to have a chance to object but I'll land it tonight if the tests are green.

radekdoulik · 2021-07-14T21:39:17Z

It should solve the release size regression. For Debug configurations we would need to change more of the build logic I think. So these lines https://github.com/dotnet/runtime/blob/main/src/mono/wasm/Makefile#L51-L55 are still needed for runtime build.

lewing · 2021-07-14T21:42:26Z

It should solve the release size regression. For Debug configurations we would need to change more of the build logic I think. So these lines https://github.com/dotnet/runtime/blob/main/src/mono/wasm/Makefile#L51-L55 are still needed for runtime build.

yeah that makes sense for the default build that ends up in the runtime pack

thaystg · 2021-07-14T21:44:34Z

It should solve the release size regression. For Debug configurations we would need to change more of the build logic I think. So these lines https://github.com/dotnet/runtime/blob/main/src/mono/wasm/Makefile#L51-L55 are still needed for runtime build.

I'm sorry, I don't understand, what do you mean by "solve the release size regression", are you talking about a release webassembly app or a release runtime?

lewing · 2021-07-14T21:46:31Z

I'm sorry, I don't understand, what do you mean by "solve the release size regression"

#55608

This should link in the stub components (debugger and hot-reload) in a Release configuration build when the workload is installed

radekdoulik · 2021-07-14T21:57:43Z

Yes, as Larry says. The webassembly app Release configuration. It can be also overriden by setting @(_MonoComponent) in the app project for now. Later we can add properly documented itemgroup or property.

lewing · 2021-07-14T22:32:38Z

@azure-pipelines
runtime (Libraries Build windows x64 Debug)

D:\workspace\_work\1\s\.dotnet\sdk\6.0.100-preview.4.21255.9\MSBuild.dll /nologo -maxcpucount /m -verbosity:m /v:minimal /bl:D:\workspace\_work\1\s\artifacts\log\Debug\ToolsetRestore.binlog /clp:Summary /clp:ErrorsOnly;NoSummary /nr:False /p:ContinuousIntegrationBuild=True /p:TreatWarningsAsErrors=true /p:__ToolsetLocationOutputFile=D:\workspace\_work\1\s\artifacts\toolset\6.0.0-beta.21359.3.txt /t:__WriteToolsetLocation /warnaserror D:\workspace\_work\1\s\artifacts\toolset\restore.proj
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json.
Build failed with exit code 1. Check errors above.
See log: D:\workspace\_work\1\s\artifacts\log\Debug\ToolsetRestore.binlog

radical · 2021-07-14T23:38:32Z

Needs a test in wasm.build.tests .

lewing · 2021-07-15T01:17:56Z

Looks like we need to fix the non-workload build for one.

lewing · 2021-07-15T16:24:01Z

The issue now looks like there is some code that expects the debugger to always exist @radical and @thaystg are looking into it

thaystg · 2021-07-15T16:24:55Z

I think I will push a fix soon.

lewing · 2021-07-15T17:40:29Z

runtime-dev-innerloop (Build windows x86 release MSBuild_CMake) is

dotnet-install: To check the list of dependencies, go to https://docs.microsoft.com/dotnet/core/install/windows#dependencies
dotnet-install: Installation finished
D:\workspace\_work\1\s\.dotnet\sdk\6.0.100-preview.4.21255.9\MSBuild.dll /nologo -maxcpucount /m -verbosity:m /v:minimal /bl:D:\workspace\_work\1\s\artifacts\log\Release\ToolsetRestore.binlog /clp:Summary /clp:ErrorsOnly;NoSummary /nr:False /p:ContinuousIntegrationBuild=True /p:TreatWarningsAsErrors=true /p:__ToolsetLocationOutputFile=D:\workspace\_work\1\s\artifacts\toolset\6.0.0-beta.21359.3.txt /t:__WriteToolsetLocation /warnaserror D:\workspace\_work\1\s\artifacts\toolset\restore.proj
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json.
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : Unable to load the service index for source https://pkgs.dev.azure.com/dnceng/public/_packaging/nuget-build/nuget/v3/index.json.
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : Unable to find package Microsoft.DotNet.Arcade.Sdk with version (= 6.0.0-beta.21359.3)
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 178 version(s) in dotnet-tools [ Nearest version: 5.0.0-beta.19558.13 ]
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 0 version(s) in richnav
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 0 version(s) in dotnet-eng
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 0 version(s) in dotnet-public
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 0 version(s) in dotnet6-transport
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 0 version(s) in dotnet6
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error : - Found 0 version(s) in nuget-build
D:\workspace\_work\1\s\artifacts\toolset\restore.proj : error MSB4236: The SDK 'Microsoft.DotNet.Arcade.Sdk' specified could not be found.
Build failed with exit code 1. Check errors above.
See log: D:\workspace\_work\1\s\artifacts\log\Release\ToolsetRestore.binlog

lewing · 2021-07-15T18:37:09Z

runtime (CoreCLR Product Build windows x64 release PGO) failed from feed errors

radical · 2021-07-15T19:14:17Z

In a follow up PR, a test could be added, eg. that converts src/tests/FunctionalTests/WebAssembly/Browser/HotReload/ to a wasm.build.tests test.

Fix helix work item prefix

lewing · 2021-07-15T20:59:20Z

runtime (CoreCLR Product Build Linux_musl arm release) is

Starting: Publish product build
==============================================================================
Task : Publish build artifacts
Description : Publish build artifacts to Azure Pipelines or a Windows file share
Version : 1.186.0
Author : Microsoft Corporation
Help : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/publish-build-artifacts
==============================================================================
Async Command Start: Upload Artifact
Async Command End: Upload Artifact
##[error]Network is unreachable
Finishing: Publish product build

microsoft/azure-pipelines-tasks#15049

lewing · 2021-07-15T21:40:47Z

This is a browser only change and the browser lanes are green.

[wasm] Support mono runtime components
003f379

radekdoulik added arch-wasm WebAssembly architecture area-Codegen-AOT-mono labels Jul 14, 2021

radekdoulik requested review from lewing and radical July 14, 2021 20:47

lewing reviewed Jul 14, 2021
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets Outdated

lewing requested a review from thaystg July 14, 2021 21:13

radekdoulik added 2 commits July 14, 2021 23:19

Do not use diagnostics_tracing component
57803d4

Allow custom @(_MonoComponent)
e680b14

radekdoulik marked this pull request as ready for review July 14, 2021 21:33

radekdoulik requested a review from marek-safar as a code owner July 14, 2021 21:33

lewing approved these changes Jul 14, 2021
View reviewed changes

lewing reviewed Jul 14, 2021
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets Outdated

Update src/mono/wasm/build/WasmApp.Native.targets
a2c89fb

runfoappBot mentioned this pull request Jul 15, 2021
System.Threading.ThreadPool.Tests failing #55711
Closed

Select components only with native workload
6aef77d

thaystg added 2 commits July 15, 2021 14:15

Fixing CI when linking with stubs
5df27a1

Adding what@radicalasked for.
dcd7149

lewing approved these changes Jul 15, 2021
View reviewed changes

radical reviewed Jul 15, 2021
View reviewed changes

Comment threadsrc/mono/wasm/build/WasmApp.Native.targets

Update sendtohelixhelp.proj
d2bbe47
Fix helix work item prefix

lewing merged commit dfdec3b into dotnet:mainJul 15, 2021

ManickaP mentioned this pull request Jul 20, 2021
[QUIC] Remove AppContext switch from S.N.Quic #56027
Merged

ghost locked as resolved and limited conversation to collaborators Aug 14, 2021

Uh oh!

Conversation

radekdoulik commented Jul 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jul 14, 2021

Uh oh!

Uh oh!

lewing left a comment

Choose a reason for hiding this comment

Uh oh!

radekdoulik commented Jul 14, 2021

Uh oh!

lewing commented Jul 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thaystg commented Jul 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Jul 14, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radekdoulik commented Jul 14, 2021

Uh oh!

lewing commented Jul 14, 2021

Uh oh!

Uh oh!

radical commented Jul 14, 2021

Uh oh!

lewing commented Jul 15, 2021

Uh oh!

lewing commented Jul 15, 2021

Uh oh!

thaystg commented Jul 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Jul 15, 2021

Uh oh!

lewing commented Jul 15, 2021

Uh oh!

Uh oh!

radical commented Jul 15, 2021

Uh oh!

lewing commented Jul 15, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Jul 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

radekdoulik commented Jul 14, 2021•
edited
Loading

lewing commented Jul 14, 2021•
edited
Loading

thaystg commented Jul 14, 2021•
edited
Loading

lewing commented Jul 14, 2021•
edited
Loading

thaystg commented Jul 15, 2021•
edited
Loading

lewing commented Jul 15, 2021•
edited
Loading