Skip to content

Make Named Pipe Server Stream name fit into allowed length on Android - #55731

Merged
stephentoub merged 6 commits into
dotnet:mainfrom
MaximLipnin:issue_55689
Jul 16, 2021
Merged

Make Named Pipe Server Stream name fit into allowed length on Android#55731
stephentoub merged 6 commits into
dotnet:mainfrom
MaximLipnin:issue_55689

Conversation

@MaximLipnin

@MaximLipninMaximLipnin commented Jul 15, 2021

Copy link
Copy Markdown
Contributor

@ghostghost added the area-System.IO label Jul 15, 2021
@ghost

ghost commented Jul 15, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

#55689

Author:MaximLipnin
Assignees:-
Labels:

area-System.IO

Milestone:-

stephentoub
stephentoub reviewed Jul 15, 2021
View reviewed changes
Comment threadsrc/libraries/System.IO.FileSystem/tests/FileStream/FileStreamConformanceTests.cs Outdated
@steveisok
steveisok marked this pull request as ready for review July 15, 2021 18:04
@MaximLipnin

MaximLipnin commented Jul 16, 2021

Copy link
Copy Markdown
ContributorAuthor

The issue with pipe name length seems to be addressed. Other issue on Android are #55821, #55822, and #55823.

@stephentoub Would you like to take another look before merging?

@stephentoub
stephentoub merged commit 0acde24 into dotnet:mainJul 16, 2021
@stephentoub

stephentoub commented Jul 16, 2021

Copy link
Copy Markdown
Member

Thanks

@MaximLipnin
MaximLipnin deleted the issue_55689 branch July 16, 2021 13:58
@MaximLipninMaximLipnin mentioned this pull request Jul 16, 2021
Closed
@adamsitnikadamsitnik added this to the 6.0.0 milestone Jul 19, 2021
@ManickaPManickaP mentioned this pull request Jul 20, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Aug 18, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes
@akoeplingerakoeplingerakoeplinger approved these changes
@stephentoubstephentoubstephentoub approved these changes
@directhexdirecthexAwaiting requested review from directhex
@mdh1418mdh1418Awaiting requested review from mdh1418

Assignees

No one assigned

Labels

area-System.IO

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@MaximLipnin@stephentoub@steveisok@akoeplinger@adamsitnik