Skip to content

Use RetryHelper to improve reliability of revocation tests - #55873

Merged
stephentoub merged 1 commit into
dotnet:mainfrom
vcsjones:retry-revocation-tests
Jul 17, 2021
Merged

Use RetryHelper to improve reliability of revocation tests#55873
stephentoub merged 1 commit into
dotnet:mainfrom
vcsjones:retry-revocation-tests

Conversation

@vcsjones

Copy link
Copy Markdown
Member

This puts the callback of the revocation tests in to a RetryHelper. This is to improve the reliability of the revocation tests, which depend on OS-specific behaviors.

Closes#48049

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

This puts the callback of the revocation tests in to a RetryHelper. This is to improve the reliability of the revocation tests, which depend on OS-specific behaviors.

Closes #48049

Author:vcsjones
Assignees:-
Labels:

area-System.Security

Milestone:-

@vcsjonesvcsjones added the test-enhancement Improvements of test source code label Jul 17, 2021
@vcsjonesvcsjones added this to the 6.0.0 milestone Jul 17, 2021
@stephentoub
stephentoub merged commit 57e7ae0 into dotnet:mainJul 17, 2021
@vcsjones
vcsjones deleted the retry-revocation-tests branch July 17, 2021 19:34
@ghostghost locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Securitytest-enhancementImprovements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: X509Certificates .. RevokeEndEntityWithInvalidRevocationName (Windows)

2 participants

@vcsjones@stephentoub