Uh oh!
There was an error while loading. Please reload this page.
[wasm] Fix invariant globalization test - #56121
Merged
Merged
Conversation
The following commit changed the behavior to throw `CultureNotFoundException` when creating cultures in invariant mode. ``` commit 04dac7b Author: Tarek Mahmoud Sayed <tarekms@microsoft.com> Date: Thu Jul 1 11:55:05 2021 -0700 Allow restricting cultures creation with any arbitrary names in Globalization Invariant Mode (dotnet#54247) ``` This commit updates the corresponding test in `Wasm.Build.Tests` to handle that explicitly. Fixesdotnet#55838
ghost
commented
Jul 22, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Jul 22, 2021
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThe following commit changed the behavior to throw This commit updates the corresponding test in Fixes #55838
|
tarekgh
approved these changes
Jul 22, 2021
radical
commented
Jul 22, 2021
MemberAuthor
Runtime test failure is #11063 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following commit changed the behavior to throw
CultureNotFoundExceptionwhen creating cultures in invariant mode.
This commit updates the corresponding test in
Wasm.Build.Teststohandle that explicitly.
Fixes#55838