Skip to content

Change reading time zone display names - #56171

Merged
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:ChangeHowWeReadTimeZoneDisplayName
Jul 23, 2021
Merged

Change reading time zone display names#56171
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:ChangeHowWeReadTimeZoneDisplayName

Conversation

@tarekgh

@tarekghtarekgh commented Jul 22, 2021

Copy link
Copy Markdown
Member

Fixes#55307

@ghost

ghost commented Jul 22, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@tarekgh

tarekgh commented Jul 22, 2021

Copy link
Copy Markdown
MemberAuthor

@mattjohnsonpint could you please have a look?

CC @safern

@tarekghtarekgh self-assigned this Jul 22, 2021
@ghost

ghost commented Jul 22, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #55307

Author:tarekgh
Assignees:-
Labels:

area-System.Runtime

Milestone:-

@tarekghtarekgh added this to the 6.0.0 milestone Jul 22, 2021
stephentoub
stephentoub reviewed Jul 22, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Win32.cs Outdated
stephentoub
stephentoub reviewed Jul 22, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Win32.cs Outdated
stephentoub
stephentoub reviewed Jul 22, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Win32.cs Outdated
stephentoub
stephentoub reviewed Jul 22, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Win32.cs Outdated
mattjohnsonpint
mattjohnsonpint reviewed Jul 22, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/TimeZoneInfo.Win32.cs Outdated
@tarekgh
tarekghforce-pushed the ChangeHowWeReadTimeZoneDisplayName branch from 0ebdcc5 to d6512b7CompareJuly 22, 2021 23:22
@tarekgh

tarekgh commented Jul 23, 2021

Copy link
Copy Markdown
MemberAuthor

The CI failures are no related. #56190

@tarekgh
tarekgh merged commit 0bd7ddc into dotnet:mainJul 23, 2021
@tarekgh
tarekgh deleted the ChangeHowWeReadTimeZoneDisplayName branch July 23, 2021 16:36
@AntonLapounov

AntonLapounov commented Jul 24, 2021

Copy link
Copy Markdown
Contributor

Thank you for fixing this!

@ghostghost locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
@safernsafernsafern approved these changes
+2 more reviewers
@AntonLapounovAntonLapounovAntonLapounov left review comments
@mattjohnsonpintmattjohnsonpintmattjohnsonpint approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tarekghtarekgh

Labels

area-System.DateTime

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Calling DateTime.Now causes memory corruption when machine has many language packs installed

6 participants

@tarekgh@AntonLapounov@mattjohnsonpint@stephentoub@safern@jeffhandley