Skip to content

Disable SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Su… - #56338

Merged
stephentoub merged 1 commit into
dotnet:release/6.0-preview7from
danmoseley:porthttp3
Jul 27, 2021
Merged

Disable SocketsHttpHandlerTest_Http3_MsQuic.ClientSettingsReceived_Su…#56338
stephentoub merged 1 commit into
dotnet:release/6.0-preview7from
danmoseley:porthttp3

Conversation

@danmoseley

Copy link
Copy Markdown
Contributor

@steveisok was hitting in P7 (eg #56255) as @karelz noted in #55774

cc @karelz

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

@steveisok was hitting in P7 (eg #56255) as @karelz noted in #55774

cc @karelz

Author:danmoseley
Assignees:-
Labels:

area-System.Net.Http

Milestone:-

@wfurt

Copy link
Copy Markdown
Member

note that any test can fail because of #55979 (and perhaps others)
It seems like disabling tests one-by-one is whack-a-mole game.

Perhaps best action for P7 is to disable QUIC/H3 tests completely.

@danmoseley

Copy link
Copy Markdown
ContributorAuthor

Ah, interesting. I picked this one as it's what they hit and it was top of the query:

TestResults
| joinkind=inner WorkItems on WorkItemId
| joinkind=inner Jobs on JobId
| where Finished >= now(-1d)
| where Type == "System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuic"//"ResponseCancellation_ServerReceivesCancellation"
| project Started, Duration, Type, Method, FriendlyName, MachineName, QueueName1, Message, StackTrace, Arguments, Branch
| summarizecount() by Type, Method
TypeMethodcount_
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuicClientSettingsReceived_Success10
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuicSendMoreThanStreamLimitRequests_Succeeds1
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuicResponseCancellation_ServerReceivesCancellation9
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuicSendMoreThanStreamLimitRequestsConcurrently_LastWaits1
System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http3_MsQuicResponseCancellation_BothCancellationTokenAndDispose_Success1

I can disable all if there's an easy way? Preview 7 is not going to build much longer though so it'd be your decision to make for main.

@karelz

Copy link
Copy Markdown
Member

I would disable just the top hitters, incl. the 9-hits: #56194
In main, we are closely monitoring the results, disabling tests and needed. The general problem #55979 will have to be addressed soon ...

@stephentoub
stephentoub merged commit d9c55e8 into dotnet:release/6.0-preview7Jul 27, 2021
@karelzkarelz added this to the 6.0.0 milestone Jul 29, 2021
@ghostghost locked as resolved and limited conversation to collaborators Aug 28, 2021
@danmoseley
danmoseley deleted the porthttp3 branch March 27, 2026 03:37
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@danmoseley@wfurt@karelz@stephentoub