Skip to content

accept empty realm for digest auth (#56369) - #56455

Merged
wfurt merged 5 commits into
dotnet:mainfrom
camillo-toselli:issue-56369
Aug 3, 2021
Merged

accept empty realm for digest auth (#56369)#56455
wfurt merged 5 commits into
dotnet:mainfrom
camillo-toselli:issue-56369

Conversation

@camillo-toselli

@camillo-tosellicamillo-toselli commented Jul 28, 2021•
edited by karelz
Loading

Copy link
Copy Markdown
Contributor

Fixes#56369

@ghostghost added area-System.Net.Http community-contribution Indicates that the PR has been added by a community member labels Jul 28, 2021
@ghost

ghost commented Jul 28, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:camillo-toselli
Assignees:-
Labels:

area-System.Net.Http, community-contribution

Milestone:-

@dnfadmin

dnfadmin commented Jul 28, 2021•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

karelz
karelz approved these changes Jul 28, 2021
View reviewed changes
Comment thread...raries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs Outdated
Comment thread...raries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs Outdated
karelz
karelz approved these changes Jul 29, 2021
View reviewed changes
Comment thread...raries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs Outdated
@wfurt

wfurt commented Jul 29, 2021

Copy link
Copy Markdown
Member

test failures seems relevant to this change. Can you please take a look @camillo-toselli ?
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-56455-merge-f548503db7b245c0b8/System.Net.Http.Functional.Tests/console.b646b8de.log?sv=2019-07-07&se=2021-08-18T11%3A37%3A35Z&sr=c&sp=rl&sig=rkUx1hMQ%2FsrXJQGcdg9A6W%2F8u981H5XnM2s99o%2F2MEc%3D

wfurt
wfurt approved these changes Aug 3, 2021
View reviewed changes

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
wfurt merged commit b0cea40 into dotnet:mainAug 3, 2021
@wfurt

wfurt commented Aug 3, 2021

Copy link
Copy Markdown
Member

thanks @camillo-toselli

thaystg added a commit to thaystg/runtime that referenced this pull request Aug 3, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_fix_debugger_break
3662e3e
# By Camillo Toselli (1) and others
# Via GitHub
* origin/main:
add RID for Debian 11 (dotnet#56789)
[wasm] [debugger] Skip thread static field (dotnet#56749)
Fix timeouts in coreroot_determinism test in GC stress mode (dotnet#56770)
Use File.OpenHandle in Socket.SendFile directly (dotnet#56777)
accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
# Conflicts:
#	src/mono/wasm/debugger/DebuggerTestSuite/BreakpointTests.cs
#	src/mono/wasm/debugger/DebuggerTestSuite/GetPropertiesTests.cs
thaystg added a commit to thaystg/runtime that referenced this pull request Aug 4, 2021
@thaystg
Merge remote-tracking branch 'origin/main' into thays_implement_debug…
33652d5
…ger_proxy_attribute
* origin/main: (340 commits)
add RID for Debian 11 (dotnet#56789)
[wasm] [debugger] Skip thread static field (dotnet#56749)
Fix timeouts in coreroot_determinism test in GC stress mode (dotnet#56770)
Use File.OpenHandle in Socket.SendFile directly (dotnet#56777)
accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
[wasm][debugger] Create test Inherited Properties (dotnet#56754)
Mark new test as incompatible with GC Mark4781_1GcStressIncompatible (dotnet#56739)
Ensure MetadataEnumResult is sufficiently updated by MetaDataImport::Enum (dotnet#56756)
[mono] Remove gdb xdebug and binary writer support, it hasn't worked in a while. (dotnet#56759)
Update windows-requirements.md (dotnet#56476)
Update doc and generic parameter name for JsonValue.GetValue (dotnet#56639)
[wasm][debugger] Inspect static class (dotnet#56740)
Fix stack overflow handling issue in GC stress (dotnet#56733)
Use ReflectionOnly as serialization mode in case dynamic code runtime feature is not supported (dotnet#56604)
Move Windows Compat pack to NuGet pack task (dotnet#56686)
Fix build error when building some packages (dotnet#56767)
Simplify JIT shutdown logic in crossgen2 (dotnet#56687)
Fix race in crossdac publishing with PGO (dotnet#56762)
Add DictionaryKeyPolicy support for EnumConverter [dotnet#47765] (dotnet#54429)
Use ComWrappers in some Marshal unit-tests and update platform metadata (dotnet#56595)
...
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Aug 11, 2021
@camillo-toselli@lucabompani
accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
237f6ec
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
This was referenced Aug 17, 2021
Closed
Closed
@karelzkarelz added this to the 6.0.0 milestone Aug 17, 2021
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Sep 21, 2021
@camillo-toselli@lucabompani
accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
382589c
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Oct 13, 2021
@camillo-toselli@lucabompani
accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
4b1f211
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
@karelz

karelz commented Nov 4, 2021

Copy link
Copy Markdown
Member

/backport to release/5.0

@dotnetdotnet unlocked this conversation Nov 4, 2021
@karelz

karelz commented Nov 4, 2021

Copy link
Copy Markdown
Member

/backport to release/5.0

@github-actions

github-actionsBot commented Nov 4, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/5.0: https://github.com/dotnet/runtime/actions/runs/1420918007

@github-actionsgithub-actionsBot mentioned this pull request Nov 4, 2021
Merged
@karelzkarelz mentioned this pull request Nov 9, 2021
Closed
bompani pushed a commit to camillo-toselli/runtime that referenced this pull request Nov 9, 2021
@camillo-toselli@lucabompani
accept empty realm for digest auth (dotnet#56369) (dotnet#56455)
510d550
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
* accept empty realm for digest auth (dotnet#56369)
Co-authored-by: Luca Bompani <luca.bompani@unibo.it>
(cherry picked from commit b0cea40)
@ghostghost locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@karelzkarelzkarelz approved these changes
@wfurtwfurtwfurt approved these changes

Assignees

No one assigned

Labels

area-System.Net.Httpcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

Digest challenge - realm fails with empty string

5 participants

@camillo-toselli@dnfadmin@wfurt@karelz@lucabompani