Uh oh!
There was an error while loading. Please reload this page.
JIT: fix pred list maintenance during fgUpdateFlowGraph - #56509
Merged
Conversation
Handle case where a BBJ_COND block both falls through and branches to another block, and we want to introduce a block to re-route the fall through. Closesdotnet#56495.
AndyAyersMS
commented
Jul 29, 2021
MemberAuthor
cc @dotnet/jit-contrib no spmi asm diffs. |
BruceForstall
approved these changes
Jul 29, 2021
EgorBo
approved these changes
Jul 29, 2021
EgorBo
reviewed
Jul 29, 2021
| fgRemoveRefPred(bDestNext, bDest); | ||
| fgAddRefPred(bFixup, bDest); | ||
| fgAddRefPred(bDestNext, bFixup); | ||
| } |
Member
There was a problem hiding this comment.
So ReplacePred should always be avoided and be replaced with a pair of RemoveRefPred + AddRefPred ?
MemberAuthor
There was a problem hiding this comment.
Not necessarily, sometimes you want to replace all the references.
I find editing flow in the jit to be fairly complex in general, especially dealing with the fall through behavior. I have ideas on how to simplify this but not sure when/if we'll get to them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle case where a BBJ_COND block both falls through and branches to
another block, and we want to introduce a block to re-route the fall through.
Closes#56495.