Skip to content

[wasm] Build Wasm.Build.Tests only on the WBT job, on CI - #56769

Merged
radical merged 4 commits into
dotnet:mainfrom
radical:build-wbt-ci
Aug 4, 2021
Merged

[wasm] Build Wasm.Build.Tests only on the WBT job, on CI#56769
radical merged 4 commits into
dotnet:mainfrom
radical:build-wbt-ci

Conversation

@radical

@radicalradical commented Aug 3, 2021

Copy link
Copy Markdown
Member

On the _WasmBuildTests job, we build the library tests also, which aren't used at all. So, disable that. And we don't need to build Wasm.Build.Tests for the regular build job, so disable there.

This saves 10-12 mins of build time.

@ghost

ghost commented Aug 3, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:radical
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@radicalradical added the arch-wasm WebAssembly architecture label Aug 3, 2021
@ghost

ghost commented Aug 3, 2021

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author:radical
Assignees:-
Labels:

arch-wasm, area-Infrastructure-mono

Milestone:-

@radical
radical marked this pull request as ready for review August 3, 2021 17:56

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It couldn't you set TestAssemblies=false and avoid the wasm specific condition in the libraries setup?

@radical

Copy link
Copy Markdown
MemberAuthor

It couldn't you set TestAssemblies=false and avoid the wasm specific condition in the libraries setup?

It is used in other cases, like the linker tests (see https://github.com/dotnet/runtime/blob/main/eng/pipelines/libraries/execute-trimming-tests-steps.yml#L7, and https://github.com/dotnet/runtime/blob/main/eng/pipelines/runtime-linker-tests.yml#L79). The intention is clearer with having an explicit property.

Comment threadeng/pipelines/runtime.yml Outdated
@radical

Copy link
Copy Markdown
MemberAuthor

runtime (Libraries Test Run release coreclr windows x64 Debug) is #56810

@radical
radical requested a review from lewingAugust 3, 2021 23:20
@lewing

Copy link
Copy Markdown
Member

I'd kind of prefer TestWasmBuild=true and dropping the only idea but it isn't a strong preference

@radical

Copy link
Copy Markdown
MemberAuthor

I'd kind of prefer TestWasmBuild=true and dropping the only idea but it isn't a strong preference

With the TestAssemblies=false change, your suggestion makes sense. I will add it to another PR that I have open.

@radical
radical merged commit 39f14c5 into dotnet:mainAug 4, 2021
@radical
radical deleted the build-wbt-ci branch August 4, 2021 15:31
@ghostghost locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@radical@lewing