[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 6 commits into from
Aug 14, 2021
Merged

[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS #57210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7952816
[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS
Aug 11, 2021
400dbab
Update skip reasons
Aug 11, 2021
8fb92db
Add MacCatalyst to Case Insensitive and remove ActiveIssues
Aug 12, 2021
cf87ed3
Replace ActiveIssue with ConditionalTheory based on RemoteExecutor
Aug 12, 2021
8d500d9
Fix test for iOS/tvOS/Catalyst
akoeplinger Aug 13, 2021
4151ce2
Skip UserName test on iOS tvOS
Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
public static bool Is64BitProcess => IntPtr.Size == 8;
public static bool IsNotWindows => !IsWindows;

public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

public static bool IsThreadingSupported => !IsBrowser;
Expand Down
4 changes: 0 additions & 4 deletions src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
}

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
[MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
{
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
};

[Theory]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
{
ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
Environment.ExitCode = 0; // in case the test host has a void returning Main
}

[Theory]
[ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
[InlineData(1)] // setting ExitCode and exiting Main
[InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
[InlineData(3)] // using Exit(exitCode)
[SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
{
int expectedExitCode = 123;
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
[SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
public void UserName_Valid()
{
string name = Environment.UserName;
Expand Down
11 changes: 6 additions & 5 deletions src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

// On non-OSX Unix, we must parse the version from uname -r
[Theory]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
[PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
[InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
[InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
[InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
[InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
[InlineData("", 0, 0, 0, 0)]
[InlineData("1abc", 1, 0, 0, 0)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
{
var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

[Fact]
[PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
[ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
{
Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
{
Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
}
Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
}

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS#57210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

danmoseley
merged 6 commits into

from

Aug 14, 2021
 Merged


[libraries] Update System.Runtime.Extensions tests for iOS,MacCatalyst,tvOS
#57210
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
7952816

[libraries] Update AppDomainTests for iOS,MacCatalyst,tvOS

Aug 11, 2021
400dbab

Update skip reasons

Aug 11, 2021
8fb92db

Add MacCatalyst to Case Insensitive and remove ActiveIssues

Aug 12, 2021
cf87ed3

Replace ActiveIssue with ConditionalTheory based on RemoteExecutor

Aug 12, 2021
8d500d9

Fix test for iOS/tvOS/Catalyst


akoeplinger Aug 13, 2021
4151ce2

Skip UserName test on iOS tvOS

Aug 13, 2021

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ public static partial class PlatformDetection
 public static bool Is64BitProcess => IntPtr.Size == 8;
 public static bool IsNotWindows => !IsWindows;

 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX;
 public static bool IsCaseInsensitiveOS => IsWindows || IsOSX || IsMacCatalyst;
 public static bool IsCaseSensitiveOS => !IsCaseInsensitiveOS;

 public static bool IsThreadingSupported => !IsBrowser;
Expand Down

4 changes: 0 additions & 4 deletions
src/libraries/System.Runtime.Extensions/tests/System/AppDomainTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -798,8 +798,6 @@ public static void GetPermissionSet()
 }

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleData))]
 public static void TestingCreateInstanceFromObjectHandle(string physicalFileName, string assemblyFile, string type, string returnedFullNameType, Type exceptionType)
 {
Expand DownExpand Up@@ -910,9 +908,7 @@ public static void TestingCreateInstanceObjectHandle(string assemblyName, string
 };

 [Theory]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/34030", TestPlatforms.Linux | TestPlatforms.Browser, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
 [MemberData(nameof(TestingCreateInstanceFromObjectHandleFullSignatureData))]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public static void TestingCreateInstanceFromObjectHandleFullSignature(string physicalFileName, string assemblyFile, string type, bool ignoreCase, BindingFlags bindingAttr, Binder binder, object[] args, CultureInfo culture, object[] activationAttributes, string returnedFullNameType)
 {
 ObjectHandle oh = AppDomain.CurrentDomain.CreateInstanceFrom(assemblyFile: assemblyFile, typeName: type, ignoreCase: ignoreCase, bindingAttr: bindingAttr, binder: binder, args: args, culture: culture, activationAttributes: activationAttributes);
Expand Down

3 changes: 1 addition & 2 deletions
src/libraries/System.Runtime.Extensions/tests/System/Environment.Exit.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -37,11 +37,10 @@ public static void ExitCode_Roundtrips(int exitCode)
 Environment.ExitCode = 0; // in case the test host has a void returning Main
 }

 [Theory]
 [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
 [InlineData(1)] // setting ExitCode and exiting Main
 [InlineData(2)] // setting ExitCode both from Main and from an Unloading event handler.
 [InlineData(3)] // using Exit(exitCode)
 [SkipOnPlatform(TestPlatforms.Android | TestPlatforms.Browser | TestPlatforms.iOS | TestPlatforms.MacCatalyst | TestPlatforms.tvOS, "Not supported on Android, Browser, iOS, MacCatalyst, or tvOS.")]
 public static void ExitCode_VoidMainAppReturnsSetValue(int mode)
 {
 int expectedExitCode = 123;
Expand Down

2 changes: 1 addition & 1 deletion
src/libraries/System.Runtime.Extensions/tests/System/Environment.UserName.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ public void UserNameIsCorrect()
 }

 [Fact]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS)]
 [SkipOnPlatform(TestPlatforms.iOS | TestPlatforms.tvOS, "Not valid on iOS or tvOS")]
 public void UserName_Valid()
 {
 string name = Environment.UserName;
Expand Down

11 changes: 6 additions & 5 deletions
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -161,7 +161,7 @@ public void OSVersion_ValidVersion()

 // On non-OSX Unix, we must parse the version from uname -r
 [Theory]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser)]
 [PlatformSpecific(TestPlatforms.AnyUnix & ~TestPlatforms.OSX & ~TestPlatforms.Browser & ~TestPlatforms.iOS & ~TestPlatforms.tvOS & ~TestPlatforms.MacCatalyst)]
 [InlineData("2.6.19-1.2895.fc6", 2, 6, 19, 1)]
 [InlineData("xxx1yyy2zzz3aaa4bbb", 1, 2, 3, 4)]
 [InlineData("2147483647.2147483647.2147483647.2147483647", int.MaxValue, int.MaxValue, int.MaxValue, int.MaxValue)]
Expand All@@ -171,7 +171,6 @@ public void OSVersion_ValidVersion()
 [InlineData("nelknet 4.15.0-24201807041620-generic", 4, 15, 0, int.MaxValue)] // integer overflow
 [InlineData("", 0, 0, 0, 0)]
 [InlineData("1abc", 1, 0, 0, 0)]
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void OSVersion_ParseVersion(string input, int major, int minor, int build, int revision)
 {
 var getOSMethod = typeof(Environment).GetMethod("GetOperatingSystem", BindingFlags.Static | BindingFlags.NonPublic);
Expand DownExpand Up@@ -333,11 +332,13 @@ public void FailFast_ExceptionStackTrace_InnerException()

 [Fact]
 [PlatformSpecific(TestPlatforms.AnyUnix | TestPlatforms.Browser)] // Tests OS-specific environment
 [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
 public void GetFolderPath_Unix_PersonalIsHomeAndUserProfile()
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 if (!PlatformDetection.IsiOS && !PlatformDetection.IstvOS && !PlatformDetection.IsMacCatalyst)
 {
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.Personal));
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments));
 }
 Assert.Equal(Environment.GetEnvironmentVariable("HOME"), Environment.GetFolderPath(Environment.SpecialFolder.UserProfile));
 }

Expand Down