[Group 3] Enable nullable annotations for `Microsoft.Extensions.FileProviders.Physical` by maxkoshevoi · Pull Request #57409 · dotnet/runtime

maxkoshevoi · 2021-08-14T18:03:52Z

Related to #43605

Annotated according to:

[Group 2] Enable nullable annotations for Microsoft.Extensions.FileProviders.Abstractions #57405

Issue to fix implementation issues: #57518

ghost · 2021-08-14T18:03:56Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2021-08-14T18:03:58Z

Tagging subscribers to this area: @maryamariyan, @dotnet/area-extensions-filesystem
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605

Annotated according to #57405

Author:	maxkoshevoi
Assignees:	-
Labels:	`new-api-needs-documentation`, `area-Extensions-FileSystem`, `community-contribution`
Milestone:	-

Issue to remove/review "!": dotnet#57518

- handle Microsoft.Extensions.FileProviders.Abstractions nullability annotations (dotnet/runtime#57405) - handle Microsoft.Extensions.FileProviders.Physical nullability annotations (dotnet/runtime#57409) - !fixup! improve `HttpConnectionDispatcher.GetConnectionToken(...)` and its use

[main] Update dependencies from dotnet/efcore dotnet/runtime - Respond to nullable annotations of `StringSegment` - general assumption is we don't create `StringValues` w/ `null` entries - in addition, `StringSegment.IsNullOrEmpty(StringSegment)` doesn't seem to help the compiler - !fixup! - Handle more nullable expressions - mostly about nullability annotations in `StringValues` and `StringSegment` - see dotnet/runtime#58223 for info about the `StringValues` -> `string` implicit conversion - Merge branch 'main' into darc-main-fcbf8a54-42e6-4ded-9535-034b26dfd6ba - Latest nullability updates - handle Microsoft.Extensions.FileProviders.Abstractions nullability annotations (dotnet/runtime#57405) - handle Microsoft.Extensions.FileProviders.Physical nullability annotations (dotnet/runtime#57409) - !fixup! improve `HttpConnectionDispatcher.GetConnectionToken(...)` and its use - Remove some `StringSegment.Value` `null` forgiveness and extra handling - e.g. `ResponseCompressionProvider` used `StringSegment.Value` when a `string` constant would do - also, `MediaTypeHeaderValue.Charset` getter unnecessarily did `StringSegment` -> `string` -> `StringSegment` - also, `CookieHeaderParserShared` ignored `[NotNullWhen(true)]` attributes in helper - !fixup! Handle `IsNullOrEmpty(...)` metadata lack - !fixup! Use `ToString()` instead of suppression - Update `KnownHeaders` - then regenerate HttpHeaders.Generated.cs - Do generated JS files need to change? - !fixup! Allow `Charset` to be `null` - !fixup! Adjust to fix failing tests - note `HttpResponse.ContentType` type now matches `HttpRequest.ContentType` - !fixup! React to `HttpResponse.ContentType` change

maxkoshevoi added 2 commits August 14, 2021 20:51

Annotate src
93f0228

Annotate ref
dacbde2

ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 14, 2021

ghost added area-Extensions-FileSystem new-api-needs-documentation labels Aug 14, 2021

maxkoshevoi added 3 commits August 14, 2021 23:03

Update PollingFileChangeToken.cs
5f23dca

Merge branch 'main' into mk/43605-FileProviders-Physical
0668b90

Update PollingFileChangeToken.cs
2139b6c

maxkoshevoi mentioned this pull request Aug 15, 2021
[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.FileExtensions#57434
Merged

maxkoshevoi changed the title ~~Enable nullable annotations for Microsoft.Extensions.FileProviders.Physical~~[Group 3] Enable nullable annotations for Microsoft.Extensions.FileProviders.PhysicalAug 15, 2021

Merge branch 'main' into mk/43605-FileProviders-Physical
a1de680

adamsitnik added this to the 7.0.0 milestone Aug 16, 2021