Skip to content

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.Binder - #57418

Merged
eerhardt merged 19 commits into
dotnet:mainfrom
maxkoshevoi:mk/43605-Configuration-Binder
Nov 18, 2021
Merged

[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.Binder#57418
eerhardt merged 19 commits into
dotnet:mainfrom
maxkoshevoi:mk/43605-Configuration-Binder

Conversation

@maxkoshevoi

@maxkoshevoimaxkoshevoi commented Aug 14, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Aug 14, 2021
@ghost

ghost commented Aug 14, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added area-Extensions-Configuration new-api-needs-documentation and removed community-contribution Indicates that the PR has been added by a community member labels Aug 14, 2021
@ghost

ghost commented Aug 14, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Related to #43605, #54012

Notes:

Author:maxkoshevoi
Assignees:-
Labels:

new-api-needs-documentation, area-Extensions-Configuration

Milestone:-

@maxkoshevoimaxkoshevoi changed the title Enable nullable annotations for Microsoft.Extensions.Configuration.Binder[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.BinderAug 15, 2021
@maryamariyanmaryamariyan added this to the 7.0.0 milestone Aug 16, 2021
@jaredparjaredpar mentioned this pull request Aug 17, 2021
Closed
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-Binder
9004a7c
@maxkoshevoi
DisableImplicitAssemblyReferences
de8bea7
@maxkoshevoi
Nullablity fix
e41470b
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-Binder
809f71d
# Conflicts:
#	src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj
#	src/libraries/Microsoft.Extensions.Configuration.Binder/ref/Microsoft.Extensions.Configuration.Binder.csproj
#	src/libraries/Microsoft.Extensions.Configuration.Binder/src/Microsoft.Extensions.Configuration.Binder.csproj
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-Binder
4f9e6d7
# Conflicts:
#	src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
@maxkoshevoi
configureOptions are non-nullable
5dac613
@maxkoshevoi
Revert "configureOptions are non-nullable"
d5e359f
This reverts commit 5dac613.
@eerhardt

eerhardt commented Oct 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@maxkoshevoi - let's concentrate on getting the Group 1, 2 and 3 libraries completed. Since it takes a lot of effort to review these PRs, and they have been sitting for a while, what do you think about closing the "Group 4" PRs for now? And we can open them again when the lower level libraries are complete?

@maxkoshevoi

maxkoshevoi commented Oct 4, 2021

Copy link
Copy Markdown
ContributorAuthor

@eerhardt What's the harm in keeping them open? They won't be reviewed until parent PRs are merged anyway (#57401 in this case). Or do you just want to do it for some internal metric?
I can convert Group 4 PRs into drafts. That also should do the trick.

@eerhardt

eerhardt commented Oct 4, 2021

Copy link
Copy Markdown
Member

What's the harm in keeping them open? Or do you just want to do it for some internal metric?

We do have an effort of trying to keep on top of our open PRs. As you can see, we currently have over 220 open PRs, some of them have been open for months with no activity.

The harm is someone coming to the PR and trying to review it, but it isn't ready to be reviewed. It also affects managing the PRs ("these ones can be reviewed" vs. "these ones are waiting for something").

@eerhardt

eerhardt commented Oct 4, 2021

Copy link
Copy Markdown
Member

I can convert Group 4 PRs into drafts.

I think that would be great for now. Thanks!

@maxkoshevoi
maxkoshevoi marked this pull request as draft October 4, 2021 19:03
@maxkoshevoi
maxkoshevoi marked this pull request as ready for review October 6, 2021 21:42
@runfoapprunfoappBot mentioned this pull request Oct 7, 2021
Closed
@maxkoshevoimaxkoshevoi mentioned this pull request Oct 13, 2021
Merged
@maxkoshevoi
Merge branch 'main' into mk/43605-Configuration-Binder
ec07505
# Conflicts:
#	src/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
eerhardt
eerhardt reviewed Nov 11, 2021
View reviewed changes
Comment thread...crosoft.Extensions.Configuration.Binder/ref/Microsoft.Extensions.Configuration.Binder.csproj Outdated
Comment thread...crosoft.Extensions.Configuration.Binder/ref/Microsoft.Extensions.Configuration.Binder.csproj Outdated
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs Outdated
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs Outdated
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs
if (item != null)
{
addMethod.Invoke(collection, new[] { item });
addMethod?.Invoke(collection, new[] { item });

@eerhardteerhardtNov 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no Add method, this will now silently no longer do anything. Is that what we want to happen?

@maxkoshevoimaxkoshevoiNov 12, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't seem to do anything before (there's an empty catch on the line bellow).

Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs Outdated
eerhardt
eerhardt approved these changes Nov 18, 2021
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution here, @maxkoshevoi.

I pushed a change that should allow CI to pass successfully. Will merge when the CI is green.

@eerhardt
eerhardt merged commit c0dabb5 into dotnet:mainNov 18, 2021
@eerhardteerhardt mentioned this pull request Nov 18, 2021
Merged
@maxkoshevoi
maxkoshevoi deleted the mk/43605-Configuration-Binder branch November 18, 2021 21:42
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardteerhardteerhardt approved these changes

Assignees

No one assigned

Labels

area-Extensions-Configurationnew-api-needs-documentation

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maxkoshevoi@eerhardt@maryamariyan