Uh oh!
There was an error while loading. Please reload this page.
Revert "[mono] Fix a few corner case overflow operations" - #57501
Conversation
This reverts commit e81efc8.
ghost
commented
Aug 16, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
SamMonoRT
commented
Aug 16, 2021
@lewing@lambdageek - can you approve this -- Vlad's original PR exposed a wasm issue |
ghost
commented
Aug 16, 2021
Hello @lambdageek! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
lewing
left a comment
There was a problem hiding this comment.
What is the emscripten bug we are hitting?
SamMonoRT
commented
Aug 16, 2021
Vlad has more details, and he was going to send email. He is on vacation this week, so possibly not going to happen until next week. |
BrzVlad
commented
Aug 18, 2021
Both in that PR and in parts of mono we rely on some undefined behavior when converting float to int. On wasm that undefined behavior resulted in some counter intuitive side effects, which turns out are allowed to happen. I will just refactor the code instead, so we don't run into undefined behavior at all in the first place. |
Reverts #57407