Skip to content

[mono] For cross builds targeting s390x use proper objcopy - #57566

Merged
lambdageek merged 1 commit into
dotnet:mainfrom
stefan-sf-ibm:objcopy-s390x
Aug 17, 2021
Merged

[mono] For cross builds targeting s390x use proper objcopy#57566
lambdageek merged 1 commit into
dotnet:mainfrom
stefan-sf-ibm:objcopy-s390x

Conversation

@stefan-sf-ibm

@stefan-sf-ibmstefan-sf-ibm commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

While cross compiling for target s390x use s390x-linux-gnu-objcopy instead of objcopy.

CC'ing @uweigand

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-Build-mono labels Aug 17, 2021
lambdageek
lambdageek approved these changes Aug 17, 2021
View reviewed changes

@lambdageeklambdageek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uweigand looks good?

@uweigand

uweigand commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

@uweigand looks good?

Yes, this LGTM.

@lambdageek
lambdageek merged commit 616ace3 into dotnet:mainAug 17, 2021
@ghostghost locked as resolved and limited conversation to collaborators Sep 17, 2021
@stefan-sf-ibm
stefan-sf-ibm deleted the objcopy-s390x branch March 25, 2022 07:28
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

area-Build-monocommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefan-sf-ibm@uweigand@lambdageek