Uh oh!
There was an error while loading. Please reload this page.
Update pinned compiler version - #57585
Conversation
ghost
commented
Aug 17, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe version that flows in automatically appears to still be old. We need to fix that, but in the meantime, we're a month out of date on the compiler.
|
Uh oh!
There was an error while loading. Please reload this page.
ViktorHofer
commented
Aug 17, 2021
The update looks good but CI is failing. |
stephentoub
commented
Aug 17, 2021
Yes, there's a new error being issued by the compiler around our use of nint/nuint. I'm following up. |
cbccfd2 to
340c665Comparestephentoub
commented
Aug 17, 2021
I suppressed the new warnings. I spoke with @jaredpar, and while they're "by design", I personally think the design is overaggressive bordering on erroneous and should be pulled back in scope. He's going to follow-up. For reference, it's now warning whenever you do things like |
akoeplinger
commented
Aug 18, 2021
There's one more error: |
340c665 to
a2131afCompareViktorHofer
commented
Aug 18, 2021
is that concerning? |
stephentoub
commented
Aug 18, 2021
The real error is here: This suggests the assembly is somehow running against a slightly old corelib; the signature of that method was updated yesterday to accept a |
jkoritzinsky
commented
Aug 18, 2021
I think the solution is to update the SDK we build against to one with your breaking API change. |
ViktorHofer
commented
Aug 18, 2021
There are no plans to upgrade the SDK to an unsigned build again unless it's strictly necessary which would require Tactics approval. |
jkoritzinsky
commented
Aug 18, 2021
Another option would be to lower the LangVersion of crossgen2 and its respective dependencies so the interpolated string builder overload isn’t picked, but I don’t know if we have a Roslyn compiler with that fix. |
jkoritzinsky
commented
Aug 18, 2021
Or it looks like #57650 should fix the test failures. |
The version that flows in automatically appears to still be old. We need to fix that, but in the meantime, we're a month out of date on the compiler.
a2131af to
64dfda6Comparestephentoub
commented
Aug 19, 2021
/backport to release/6.0 |
stephentoub
commented
Aug 19, 2021
/backport to release/6.0-rc1 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1147169213 |
Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1147169460 |
The version that flows in automatically appears to still be old. We need to fix that, but in the meantime, we're a month out of date on the compiler.