Skip to content

Adding unit test for ScopeDisposed tracing event in DI - #57591

Merged
eerhardt merged 1 commit into
dotnet:mainfrom
allantargino:issue-56313-di-test-event
Aug 19, 2021
Merged

Adding unit test for ScopeDisposed tracing event in DI#57591
eerhardt merged 1 commit into
dotnet:mainfrom
allantargino:issue-56313-di-test-event

Conversation

@allantargino

@allantarginoallantargino commented Aug 17, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds a missing test for ScopeDisposed tracing event in Dependency Injection extension.

The event was introduced in #51163, but I am using #56809 test conventions.

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-Extensions-DependencyInjection labels Aug 17, 2021
@ghost

ghost commented Aug 17, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Adds a missing test for ScopeDisposed tracing event in Dependency Injection extension.

The feature was introduced in #51163, but I am using #56809 test conventions.

Author:allantargino
Assignees:-
Labels:

area-Extensions-DependencyInjection, community-contribution

Milestone:-

@dnfadmin

dnfadmin commented Aug 17, 2021•
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@allantarginoallantargino changed the title Missing test for ScopeDisposed in DI tracing eventAdding test for ScopeDisposed in DI tracing eventAug 18, 2021
@allantarginoallantargino changed the title Adding test for ScopeDisposed in DI tracing eventAdding unit test for ScopeDisposed tracing event in DIAug 18, 2021
eerhardt
eerhardt approved these changes Aug 19, 2021
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@eerhardt
eerhardt merged commit f3b77e6 into dotnet:mainAug 19, 2021
@allantargino
allantargino deleted the issue-56313-di-test-event branch August 24, 2021 20:13
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardteerhardteerhardt approved these changes

Assignees

No one assigned

Labels

area-Extensions-DependencyInjectioncommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@allantargino@dnfadmin@eerhardt