Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Throw on invalid payload length in WebSockets - #57636
Merged
Conversation
ghost
commented
Aug 18, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #57598 to release/6.0 /cc @CarnaViire Customer ImpactTestingRisk
|
karelz
approved these changes
Aug 18, 2021
Member
Failures are infra issues, not related to the PR:
Re-running CI just in case ... |
jeffschwMSFT
approved these changes
Aug 18, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. With a green CI we should merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57598 to release/6.0
/cc @CarnaViire
Port of 9eb5680
Customer Impact
Avoid integer overflow to prevent infinite loop in reading from WebSocket. (also complies better with WebSocket RFC)
MSRC 65273 - Prevents DoS attack by sending frames with invalid payload length.
Testing
Unit test included in PR
Risk
Low