Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] [mono] Fix crash in common_call_trampoline due to inconsistent rgctx mode - #57676
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[release/6.0] [mono] Fix crash in common_call_trampoline due to inconsistent rgctx mode#57676github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…mode * Assume MRGCTX mode if mini_method_is_default_method is true * Fixes#57664
github-actionsBot
requested review from
SamMonoRT, imhameed, lambdageek and vargaz
as code ownersAugust 18, 2021 18:14
ghost
commented
Aug 18, 2021
Tagging subscribers to this area: Issue DetailsBackport of #57665 to release/6.0 Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Aug 19, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a CR and we can merge for RC2.
ViktorHofer
commented
Aug 19, 2021
Member
Closing as #57677 will automatically flow into release/6.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57665 to release/6.0
/cc @lambdageek@uweigand
Customer Impact
Code using generic default interface methods may crash when using the Mono (e.g. on Android or ios emulators or devices).
Testing
Manual testing.
Risk
Moderate - we can turn off generic sharing in the JIT, but not FullAOT.