Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix incorrect VN when folding GT_NEG(GT_MUL(A, C)) - #57686
Merged
Conversation
ghost
commented
Aug 18, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #57651 to release/6.0 /cc @jakobbotsch Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Aug 19, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a CR and we can merge for RC2.
EgorBo
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57651 to release/6.0
/cc @jakobbotsch
Customer Impact
Results in silent bad codegen with certain programming constructs, however the case was found by automated test case generation and not a customer.
Testing
Regression tests are included in the PR.
Risk
Low, this is a targeted fix that updates the stale data leading to the bad codegen.