Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix QUIC ConnectionState NRE in HandleEventConnectionClose - #57742
Conversation
ghost
commented
Aug 19, 2021
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #57655 to release/6.0 /cc @CarnaViire Customer ImpactTestingRisk
|
ViktorHofer
commented
Aug 20, 2021
@karelz is this ready to be merged (after looking at the one failure in the PR)? Asking as I noticed failures because of this in unrelated PRs targeting release/6.0. |
CarnaViire
commented
Aug 20, 2021
|
@CarnaViire when seeing unrelated failures, can you please link to their corresponding issues (and if such don't exist yet, open one and link to it)? That makes sure that all failures are tracked. For more info see https://github.com/dotnet/runtime/blob/main/docs/pr-guide.md#option-2-there-is-a-flaky-test-that-is-not-related-to-your-pr |
Unrelated failures in runtime-staging pipeline are: |
danmoseley
commented
Aug 23, 2021
Approved for release/6.0 -- CI impact, localized change. |
Backport of #57655 to release/6.0
Moved ConnectionState assignment before msquic callback registration to avoid NRE in callback, in case Connection gets closed during Stream's ctor.
Fixes#55815
/cc @CarnaViire
Customer Impact
It started hurting our CI on 8/17 badly: #55815 (comment)
Testing
CI passed. No new failures in main since merging #57655 (failures in release/6.0 still happen)
The issue is race condition, hard to test in any other way.
Risk
Low, QUIC and H/3 are hidden behind AppContext switch