Skip to content

Change hosted pool - #57785

Merged
Anipik merged 3 commits into
dotnet:release/5.0from
ulisesh:Use1ESBuildPool
Nov 4, 2021
Merged

Change hosted pool#57785
Anipik merged 3 commits into
dotnet:release/5.0from
ulisesh:Use1ESBuildPool

Conversation

@ulisesh

@uliseshulisesh commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

We have a new set of AzDo pools where we eventually will move all servicing work, this PR tests Build.Ubuntu.1804.Amd64.Open

@ghost

ghost commented Aug 19, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We have a new set of AzDo pools where we eventually will move all servicing work, this PR tests Build.Ubuntu.1804.Amd64.Open

Author:ulisesh
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@ulisesh
ulisesh requested a review from safernAugust 20, 2021 18:56
ViktorHofer
ViktorHofer reviewed Sep 1, 2021
View reviewed changes

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you are mentioning "testing" in the PR description, do you want this to get merged or is the PR just testing the pools?

@ulisesh

ulisesh commented Sep 1, 2021

Copy link
Copy Markdown
ContributorAuthor

As you are mentioning "testing" in the PR description, do you want this to get merged or is the PR just testing the pools?

I want to merge it :)

MattGal
MattGal approved these changes Sep 1, 2021
View reviewed changes

@MattGalMattGal left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks valid, I'd merge if it passes your builds. (Edit; it did and the only test failures are that xunit thing and system.drawing on Arm64 which is very unlikely to be related)

@ulisesh

ulisesh commented Sep 1, 2021

Copy link
Copy Markdown
ContributorAuthor

looks valid, I'd merge if it passes your builds. (Edit; it did and the only test failures are that xunit thing and system.drawing on Arm64 which is very unlikely to be related)

Agree, I don't think Arm64 test failures are related to this change. @ViktorHofer, who is a good person to merge this? It looks like a don't have enough permissions

@ViktorHoferViktorHofer mentioned this pull request Sep 1, 2021
Open
@uliseshulisesh mentioned this pull request Sep 1, 2021
Merged
@ViktorHofer

ViktorHofer commented Sep 1, 2021

Copy link
Copy Markdown
Member

Issues are:

@ViktorHofer

ViktorHofer commented Sep 1, 2021

Copy link
Copy Markdown
Member

Oh just before merging noticed that this targets release/5.0. @Anipik can we merge the PR or is the branch closed?

@ulisesh

ulisesh commented Sep 1, 2021

Copy link
Copy Markdown
ContributorAuthor

This pools are specific for Servicing work in release branches

@ulisesh

ulisesh commented Sep 2, 2021

Copy link
Copy Markdown
ContributorAuthor

@ViktorHofer can you please help us merge this PR too? It is the same change we did in #58484

@ViktorHofer

ViktorHofer commented Sep 3, 2021

Copy link
Copy Markdown
Member

I don't manage the servicing branches. Ping @Anipik for my question above.

@Anipik

Anipik commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

The branch is currently closed. i will merge this one when the branch will open for the next servicing release

@ericstjericstj assigned ulisesh and Anipik and unassigned uliseshSep 27, 2021
@ericstj

ericstj commented Sep 27, 2021

Copy link
Copy Markdown
Member

@Anipik is this ready to go yet?

@AnipikAnipik added the Servicing-approved Approved for servicing release label Oct 25, 2021
@Anipik

Anipik commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

adding servicing approved so i dont miss this one for the next release

@Anipik
Anipik merged commit 7b19c71 into dotnet:release/5.0Nov 4, 2021
@ghostghost locked as resolved and limited conversation to collaborators Dec 4, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@MattGalMattGalMattGal approved these changes
@safernsafernsafern approved these changes
@AnipikAnipikAwaiting requested review from Anipik

Assignees

@AnipikAnipik

Labels

area-Infrastructure-librariesServicing-approvedApproved for servicing release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ulisesh@ViktorHofer@Anipik@ericstj@MattGal@safern