Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] [mono][debugger] Fix watch of local variable values - #57787
Merged
Conversation
github-actionsBot
requested review from
SamMonoRT, imhameed, lambdageek, marek-safar, thaystg and vargaz
as code ownersAugust 19, 2021 22:44
ghost
commented
Aug 19, 2021
Tagging subscribers to this area: @thaystg |
jeffschwMSFT
approved these changes
Aug 19, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and we can request consideration for RC1.
lewing
approved these changes
Aug 19, 2021
lewing
commented
Aug 20, 2021
Member
approved in email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57771 to release/6.0-rc1
/cc @thaystg
Customer Impact
Fixesdotnet/android#6161
Testing
Added a test case for newer protocol versions and manually tested for android (older protocol version).
Risk
It's using an old code for older protocol versions. No risk.