Skip to content

Pack windows implementation assemblies in windowsdesktop transport package - #57795

Merged
ViktorHofer merged 1 commit into
dotnet:mainfrom
ericstj:fixWindowsTransportPackage
Aug 20, 2021
Merged

Pack windows implementation assemblies in windowsdesktop transport package#57795
ViktorHofer merged 1 commit into
dotnet:mainfrom
ericstj:fixWindowsTransportPackage

Conversation

@ericstj

@ericstjericstj commented Aug 20, 2021

Copy link
Copy Markdown
Member

Fixes#57791

@ghost

ghost commented Aug 20, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #57791

Author:ericstj
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@ericstj

ericstj commented Aug 20, 2021

Copy link
Copy Markdown
MemberAuthor

This will need to be ported to RC1 to unblock winforms.

@ericstj

ericstj commented Aug 20, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc1

@github-actions

github-actionsBot commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1149127242

RussKie
RussKie approved these changes Aug 20, 2021
View reviewed changes

@RussKieRussKie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actionsgithub-actionsBot mentioned this pull request Aug 20, 2021
Merged
ViktorHofer
ViktorHofer approved these changes Aug 20, 2021
View reviewed changes

@ViktorHoferViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to double check that that's the right metadata. Thanks, I completely forgot making sure that the right rid tfm pair gets in.

@ViktorHofer
ViktorHofer merged commit 3dba803 into dotnet:mainAug 20, 2021
@ViktorHofer

ViktorHofer commented Aug 20, 2021

Copy link
Copy Markdown
Member

Did you consider changing the target framework instead to we windows specific?

@ericstj

ericstj commented Aug 20, 2021

Copy link
Copy Markdown
MemberAuthor

I tried to change the project framework but that required a larger change to the targets that pack this project as they ended up packing as net6.0-windows This change was the smallest that fixed the issue.

@ghostghost locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer approved these changes
@AnipikAnipikAwaiting requested review from Anipik
+1 more reviewer
@RussKieRussKieRussKie approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unhandled exception about "System.Drawing.Common is not supported on this platform" occurs when running winforms application

3 participants

@ericstj@ViktorHofer@RussKie