Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] [hot_reload] Don't look at delta method table rows - #57799
Merged
Conversation
Call a method for the first time after an update has been applied to it. This will check that the interpreter or JIT does not have to rely on cached information from the baseline (about the method signature, for example) and that it can compute it from the delta.
The issue is that the ParamList column in EnC deltas is a "suppressed column" that has the value 0. So when a method is updated if we use the value directly, we will break, for example - `mono_metadata_get_param_attrs` which expects a non-zero index in that column. CoreCLR solves this by having a set of suppressed columns that are never updated by deltas. (CoreCLR's model is to directly mutate the tables of the baseline image). In Mono we can eventually do the same thing by writing the value from the previous generation into the current delta's row. But right now since we don't allow parameter modifications, and the only column on a Method table that we allow to be modified is the RVA - which we look up specially - we can just always return the baseline image row for the method table. Fixes#57643
ghost
commented
Aug 20, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jeffschwMSFT
approved these changes
Aug 20, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and we can send an request for approval for RC1.
thaystg
approved these changes
Aug 20, 2021
lewing
commented
Aug 20, 2021
Member
approved in email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57798 to release/6.0-rc1
/cc @lambdageek
Customer Impact
When using hot reload, making changes to a method that has not been executed yet, and then executing it, results in a crash.
Testing
CI and manual testing
Risk
Low - changes to methods that have already been executed can be applied. Restarting the app is also always a possible workaround.
Fixes#57643