Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] Add event to RuntimeEventSource for AppContext switches - #57847
Merged
Conversation
ghost
commented
Aug 20, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lewing
commented
Aug 22, 2021
Member
This needs #57890 before it should go in. |
* Skip RuntimeEventSource tests on wasm and android * Skip tests without using issues.targets * Disable test for mono (cherry picked from commit 454ac57)
jeffschwMSFT
approved these changes
Aug 24, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and we can merge.
jeffschwMSFT
commented
Aug 24, 2021
Member
@Anipik we are good to merge. Is now a good time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57303 to release/6.0-rc1
/cc @agocke
Customer Impact
Adds event gathering for AppContext switches, helpful for diagnosing issues related to feature flags, or other runtime configurations.
Testing
Unit tests, manual verification.
Risk
Low