Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] MonoAOTCompiler: Check for proxy file's target only when the cache is… - #57867
Merged
steveisok merged 1 commit intoAug 24, 2021
Conversation
… being .. used. Fixesdotnet#57800 .
lewing
commented
Aug 24, 2021
Member
@jonathanpeppers I want to understand the impact here. Is this scenario important for RC1 one or just important for release? |
jonathanpeppers
commented
Aug 24, 2021
Member
@lewing if needed, you could just backport this to |
steveisok
self-requested a review
August 24, 2021 19:22
steveisok
approved these changes
Aug 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57865 to release/6.0-rc1
/cc @radical
Customer Impact
Fixes the Android build when llvm and aot are enabled. The underlying problem was incorrectly checking for the existence of a file in a configuration where where it did not exist. The fix moves the check into the correct condition.
Testing
Manual testing
Risk
Low - only runs a check when under the correct condition.
Fixes#57800 .
Backport of #57865 to release/6.0-rc1