Uh oh!
There was an error while loading. Please reload this page.
Stop using ERR_GET_FUNC, since it has been removed in OSSL3 Beta2. - #57869
Conversation
ghost
commented
Aug 20, 2021
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsRestructure CryptoNative_LookupFriendlyNameByOid to not depend on the so-deprecated-its-removed ERR_GET_FUNC. This approach calls a2d_ASN1_OBJECT directly, rather than looking for it having been the source of the error. While noodling around in the function, I noticed that there was a small memory leak, so now that's fixed, too. Fixes #57674 (in main).
|
Uh oh!
There was an error while loading. Please reload this page.
stephentoub
commented
Aug 21, 2021
Does this need to be backported? |
bartonjs
commented
Aug 21, 2021
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1153824338 |
Restructure CryptoNative_LookupFriendlyNameByOid to not depend on the so-deprecated-its-removed ERR_GET_FUNC.
This approach calls a2d_ASN1_OBJECT directly, rather than looking for it having been the source of the error.
While that does make for double work on success, it's just a state walker for a short string, so it's not too bad.
While noodling around in the function, I noticed that there was a small memory leak, so now that's fixed, too.
Fixes#57674 (in main).