Skip to content

Apply feedback from PR #57204 - #57872

Merged
maryamariyan merged 2 commits into
dotnet:mainfrom
maryamariyan:fix-binding
Aug 23, 2021
Merged

Apply feedback from PR #57204#57872
maryamariyan merged 2 commits into
dotnet:mainfrom
maryamariyan:fix-binding

Conversation

@maryamariyan

@maryamariyanmaryamariyan commented Aug 20, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Caching context switch check
  • Using remote task executor in test

/cc @vidommet

@ghost

ghost commented Aug 20, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @maryamariyan, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

cc @vidommet

Author:maryamariyan
Assignees:-
Labels:

area-Extensions-Configuration

Milestone:-

eerhardt
eerhardt reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/tests/ConfigurationBinderTests.cs Outdated
eerhardt
eerhardt reviewed Aug 23, 2021
View reviewed changes
Comment threadsrc/libraries/Microsoft.Extensions.Configuration.Binder/src/ConfigurationBinder.cs Outdated
eerhardt
eerhardt approved these changes Aug 23, 2021
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryamariyan
maryamariyan merged commit e4a455f into dotnet:mainAug 23, 2021
maryamariyan added a commit to maryamariyan/runtime that referenced this pull request Aug 24, 2021
@maryamariyan
Apply feedback from PRdotnet#57204(dotnet#57872)
537bbfb
@maryamariyanmaryamariyan mentioned this pull request Aug 24, 2021
Merged
ericstj pushed a commit that referenced this pull request Aug 25, 2021
@maryamariyan@vidommet
Allow configuration binder to bind single elements to array (#58060)
c8159b3
* Allow ConfigBinder to bind arrays to Singular elements (#57204)
* Apply feedback from PR #57204 (#57872)
Co-authored-by: vidommet <80355385+vidommet@users.noreply.github.com>
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardteerhardteerhardt approved these changes
@ericstjericstjAwaiting requested review from ericstj

Assignees

No one assigned

Labels

area-Extensions-Configuration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maryamariyan@eerhardt