Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] Support reference type custom converters in source gen - #57954
Merged
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersAugust 23, 2021 17:48
ghost
commented
Aug 23, 2021
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsBackport of #57592 to release/6.0-rc1 /cc @steveharter Customer ImpactTestingRisk
|
eiriktsarpalis
approved these changes
Aug 24, 2021
mmitche
commented
Aug 25, 2021
Member
Merge when ready |
steveharter
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57592 to release/6.0-rc1
This PR replaces #57772 which only targeted release/6.0.
Fixes#56864
/cc @steveharter
Customer Impact
Broken scenario: custom converters based on reference types result in a compile error when the custom converter is applied to a property via [JsonConverter]; no feasible workaround other than to remove the [JsonConverter] attribute.
Testing
New tests added to verify struct-based and reference-type-based custom converters.
Risk
Low - changes are local to source-gen support of custom converters.