Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fixed StreamPipeReader.CopyToAsync - #57965
Closed
github-actions[bot] wants to merge 2 commits into
Closed
[release/6.0] Fixed StreamPipeReader.CopyToAsync#57965github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
…unt when copying buffered data. This handles the case where ReadAsync has consumed a partial segment and then the same PipeReader instance is used to copy to a Stream and PipeWriter. - Added tests
halter73
approved these changes
Aug 23, 2021
ViktorHofer
commented
Aug 24, 2021
Member
@davidfowl just FYI, release/6.0-rc1 commits are automatically flowing into release/6.0 (rc2). |
davidfowl
commented
Aug 24, 2021
Member
Ah good. |
davidfowl
commented
Aug 24, 2021
Member
So I can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #57943 to release/6.0
/cc @davidfowl
Customer Impact
We introduced a regression in StreamPipeReader when doing performance optimizations in .NET 6. This could lead to silent corruption of data when using the CopyToAsync method.
Testing
Unit testing.
Risk
Very Low.