[wasm][debugger] Proxy but don't process events from worker sessions

[lewing]

Should Fix#57949

@thaystg can you see if you can construct a test for this?

[ghost]

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Should Fix #57949

@thaystg can you see if you can construct a test for this?

Author:	lewing
Assignees:	-
Labels:	area-Debugger-mono
Milestone:	-

It's not compiling

[radical]

Isn't the same check needed for Runtime.consoleAPICalled, Target.attachedToTarget, and Target.targetDestroyed?

[lewing]

Isn't the same check needed for Runtime.consoleAPICalled, Target.attachedToTarget, and Target.targetDestroyed?

Not exactly, those don't expect the context to exist in the same way:
Runtime.consoleAPICalled only does work when a mono runtime is executing.
Target.AttachedToTarget really does work on those sessions
Target.targetDestroyed will fail to evaluate on the js side but it should be harmless.

[radical]

Isn't the same check needed for Runtime.consoleAPICalled, Target.attachedToTarget, and Target.targetDestroyed?

Not exactly, those don't expect the context to exist in the same way:
Runtime.consoleAPICalled only does work when a mono runtime is executing.

What are the "worker sessions" mentioned in the title? Are these sessions executing while the mono runtime is also executing? If so, then couldn't we receive this message for a non-mono session?

Looking at the code, it's handling two mono [1][2] specific cases, so it won't be a problem with that, IIUC. But if we can receive messages not meant for us, then it might still be a good idea to check in that case, and proxy the message?

[lewing]

Isn't the same check needed for Runtime.consoleAPICalled, Target.attachedToTarget, and Target.targetDestroyed?

Not exactly, those don't expect the context to exist in the same way:
Runtime.consoleAPICalled only does work when a mono runtime is executing.

What are the "worker sessions" mentioned in the title? Are these sessions executing while the mono runtime is also executing? If so, then couldn't we receive this message for a non-mono session?

https://developer.mozilla.org/en-US/docs/Web/API/Worker

Looking at the code, it's handling two mono [1][2] specific cases, so it won't be a problem with that, IIUC. But if we can receive messages not meant for us, then it might still be a good idea to check in that case, and proxy the message?

I'm not sure I follow? In the cases where it isn't from mono it does get proxied.

[lewing]

/backport to release/6.0-rc1

[github-actions]

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1160816690