Skip to content

Make SendFile_NonParallel<T> abstract - #58003

Merged
antonfirsov merged 1 commit into
mainfrom
antonfirsov/SendFile_NonParallel-abstract
Aug 24, 2021
Merged

Make SendFile_NonParallel<T> abstract#58003
antonfirsov merged 1 commit into
mainfrom
antonfirsov/SendFile_NonParallel-abstract

Conversation

@antonfirsov

@antonfirsovantonfirsov commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

Minor, but important addition to #57946, test base class should have been made abstract, without that tests are failing.

Fixes#57907

/cc @ManickaP

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Minor, but important addition to #57946, test base class should have been made abstract.

/cc @ManickaP

Author:antonfirsov
Assignees:-
Labels:

area-System.Net.Sockets

Milestone:-

@antonfirsov

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@karelz

Copy link
Copy Markdown
Member

Hitting unrelated test failures:

Re-running failing legs

@antonfirsov

Copy link
Copy Markdown
ContributorAuthor

We are still hitting external outages with HttpClientHandler_RemoteServerTest, which is unrelated.

@antonfirsov
antonfirsov merged commit 0d3ce71 into mainAug 24, 2021
@akoeplinger
akoeplinger deleted the antonfirsov/SendFile_NonParallel-abstract branch August 28, 2021 22:04
@ghostghost locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure System.Net.Sockets.Tests.SendFile_CancellableTask.GreaterThan2GBFile_SendsAllBytes

3 participants

@antonfirsov@karelz@ManickaP