Skip to content

[mono] Support RuntimeType.MakeGenericType with non-RuntimeType elements - #58014

Merged
lewing merged 1 commit into
dotnet:mainfrom
uweigand:mono-runtimetype
Aug 27, 2021
Merged

[mono] Support RuntimeType.MakeGenericType with non-RuntimeType elements#58014
lewing merged 1 commit into
dotnet:mainfrom
uweigand:mono-runtimetype

Conversation

@uweigand

@uweiganduweigand commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-CoreLib-mono labels Aug 24, 2021
@jkotas

jkotas commented Aug 24, 2021

Copy link
Copy Markdown
Member

Do we need to add test?

@lewing

lewing commented Aug 24, 2021

Copy link
Copy Markdown
Member

runtime (Libraries Test Run release mono Linux arm64 Debug) hit #57941

@SamMonoRT

SamMonoRT commented Aug 26, 2021

Copy link
Copy Markdown
Member

@uweigand - can we get a test added for the change ?

@uweigand

uweigand commented Aug 27, 2021

Copy link
Copy Markdown
ContributorAuthor

Added test case. The test fails on Mono without this patch and passes with it. In any case it passes with CoreCLR.

If there is a more straightforward way to create a non-RuntimeType type, I'd appreciate any suggestions ...

@jkotas

jkotas commented Aug 27, 2021

Copy link
Copy Markdown
Member

If there is a more straightforward way to create a non-RuntimeType type

I think new MockType() should work.

Or include Common\tests\System\NonRuntimeType.cs in the project and use new NonRuntimeType().

@uweigand

uweigand commented Aug 27, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

If there is a more straightforward way to create a non-RuntimeType type

I think new MockType() should work.

Or include Common\tests\System\NonRuntimeType.cs in the project and use new NonRuntimeType().

Thanks for the pointers! While investigating those, I found Helpers.NonRuntimeTypes which is already used in similar tests, so I used this here as well.

jkotas
jkotas approved these changes Aug 27, 2021
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@marek-safar

marek-safar commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

/backport to release/6.0

@github-actions

github-actionsBot commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1174964346

@github-actionsgithub-actionsBot mentioned this pull request Aug 27, 2021
Merged
@lewing
lewing merged commit 510f63e into dotnet:mainAug 27, 2021
@uweigand
uweigand deleted the mono-runtimetype branch August 30, 2021 07:47
@ghostghost locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@jkotasjkotasjkotas approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar

Assignees

No one assigned

Labels

community-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[mono] RuntimeType.MakeGenericType with non-RuntimeType elements not supported

6 participants

@uweigand@jkotas@lewing@SamMonoRT@marek-safar@lambdageek